Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/vmware/govmomi from 0.37.3 to 0.38.0 #2229

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 25, 2024

Bumps github.com/vmware/govmomi from 0.37.3 to 0.38.0.

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.38.0

Release v0.38.0

Release Date: 2024-06-24

🐞 Fix

  • [22607cd8] xml marshal byte array fields as vCenter does (#1977) (#3469)
  • [298cfbf3] govc vm.disk.change should only modify CapacityInBytes (#3424) (#3464)

💫 API Changes

  • [0de9553a] EnsureDisksHaveControllers helper
  • [3d70ab5c] OptionValueList helper
  • [d80136a5] add storage_specs field to Namespace related structures
  • [748043cd] add pbm.DatastoreMap for finding compatible Datastores
  • [fc2a6b12] HardwareVersion.IsSupported vs IsValid
  • [a68c21f2] Add library item storage APIs
  • [7d1be3e7] Update ConfigInfoToConfigSpec
  • [12ab4099] Update generated types
  • [45aa2e92] add checksum validation in Content Library update session file API
  • [7a00a0b4] Generate enum consts with Values funcs
  • [f2852e39] add SSLCertificate to TransferEndpoint in content library API (#3420)

💫 govc (CLI)

  • [c3c5ffba] add vsan.info -file-service-enabled flag
  • [a916df4e] add host.tpm.info and host.tpm.report commands
  • [7f0c9f0c] add host.cert.info -show flag
  • [ae316d65] add storage.policy.create zonal option
  • [3e648db2] add '-storage' flag to namespace.create and namespace.update commands
  • [e7d54f90] add vm.create '-profile' and '-place' flags
  • [5677b0e5] Add feature to pass fullname and org for windows vm customization (#3443)

💫 vcsim (Simulator)

  • [e9f4cb73] add vSAN FileServiceConfig support (#3430)
  • [072011c6] add HostCertificateManager
  • [a0bbbf3f] add library item storage API support (#3213)
  • [3b7ff25f] add PropertyCollector index support
  • [651f7d27] fix: ignore unknown refs in Datacenter.PowerOnMultiVM
  • [7251db75] Add PbmCheckCompatibility method in pbm simulator
  • [542398a2] add HostVirtualNicManager
  • [0be5fec8] fix ReconfigVM validation when changing disk size (#3423)

🧹 Chore

  • [51648874] Update version.go for v0.38.0

... (truncated)

Commits
  • 5164887 chore: Update version.go for v0.38.0
  • c1d0832 Merge pull request #3432 from dougm/vcsim-vsan-file-service
  • 34c3788 Merge pull request #3476 from dougm/fix-byte-array
  • c3c5ffb govc: add vsan.info -file-service-enabled flag
  • e9f4cb7 vcsim: add vSAN FileServiceConfig support
  • 43510fb chore: make doc
  • a916df4 govc: add host.tpm.info and host.tpm.report commands
  • 072011c vcsim: add HostCertificateManager
  • 7f0c9f0 govc: add host.cert.info -show flag
  • 22607cd fix: xml marshal byte array fields as vCenter does
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
github.com/vmware/govmomi [>= 0.33.a, < 0.34]
github.com/vmware/govmomi [< 0.37, > 0.36.1]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.37.3 to 0.38.0.
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.37.3...v0.38.0)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner June 25, 2024 04:49
@dependabot dependabot bot added dependencies Type: Dependencies go labels Jun 25, 2024
@github-actions github-actions bot added provider Type: Provider chore Type: Chore needs-review Status: Pull Request Needs Review labels Jun 25, 2024
@tenthirtyam tenthirtyam added this to the v2.8.2 milestone Jun 25, 2024
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@tenthirtyam tenthirtyam marked this pull request as draft June 25, 2024 16:04
Copy link
Collaborator

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of validation errors.

I pulled the branch locally and the problem is real

HWRQ7QD9K0:terraform-provider-vsphere zhelyazkovs$ go install
# github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/contentlibrary
vsphere/internal/helper/contentlibrary/content_library_helper.go:65:88: undefined: library.StorageBackings
vsphere/internal/helper/contentlibrary/content_library_helper.go:456:82: undefined: library.StorageBackings
vsphere/internal/helper/contentlibrary/content_library_helper.go:458:18: undefined: library.StorageBackings
vsphere/internal/helper/contentlibrary/content_library_helper.go:464:27: undefined: library.StorageBackings
vsphere/internal/helper/contentlibrary/content_library_helper.go:505:66: undefined: library.StorageBackings

Looks like library.StorageBackings was renamed to library.StorageBacking

https://github.com/vmware/govmomi/pull/3442/files#diff-bef58bf2c0e9ce8d41383a137f8804a78dfedf298a4e11596a7daf41e1d75734L32

Signed-off-by: Stoyan Zhelyazkov <[email protected]>
tenthirtyam referenced this pull request in vmware/govmomi Jun 26, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review June 26, 2024 12:15
@tenthirtyam tenthirtyam merged commit 16affb6 into main Jun 26, 2024
7 checks passed
@tenthirtyam tenthirtyam deleted the dependabot/go_modules/github.com/vmware/govmomi-0.38.0 branch June 26, 2024 12:16
Copy link

This functionality has been released in v2.8.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 29, 2024
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Type: Chore dependencies Type: Dependencies provider Type: Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants