bugfix: Remove default values for ept_rvi_mode and hv_mode #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
iBrandyJackson
approved these changes
Apr 19, 2024
tenthirtyam
approved these changes
Apr 19, 2024
4 tasks
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm removing the default values for
ept_rvi_modeandhv_modefrom the virtual machine configuration.These properties are overwritten during the "read" phase and cause in uplace updates on the VM even if the configuration hasn't changed.
We should allow the vCenter to control the defaults instead of setting them ourselves
Acceptance tests
Ran
TestAccResourceVSphereVirtualMachine_basicManually tested by applying the same confguration twice
Release Note
Release note for CHANGELOG:
References
#1902