Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vm folder when querying for vm #2118

Merged

Conversation

vasilsatanasov
Copy link
Contributor

@vasilsatanasov vasilsatanasov commented Jan 21, 2024

Description

  • Added the VM folder in the search for VMs criteria in deploy from OVF scenario.
  • Added an e2e test. Verified that when the VM folder is not strictly specified the OVF deploy is passing. The query is in the default VM folder.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

API server listening at: 127.0.0.1:65413
=== RUN   TestAccResourceVSphereVirtualMachine_deployOvfFromUrlMultipleVmsSameName
--- PASS: TestAccResourceVSphereVirtualMachine_deployOvfFromUrlMultipleVmsSameName (162.90s)
PASS

Debugger finished with the exit code 0

Release Note

`r/virtual_machine`: Added the virtual machine folder in the search for virtual machine criteria when deploying from an OVF/OVA. scenario. Allows virtaul machines with same names in different virtual machine folders to be not distinguished as different managed entities. [GH 2118](https://github.com/hashicorp/terraform-provider-vsphere/pull/2118)

References

Closes #1524

@vasilsatanasov vasilsatanasov requested a review from a team as a code owner January 21, 2024 12:29
@tenthirtyam tenthirtyam added the bug Type: Bug label Jan 22, 2024
@tenthirtyam tenthirtyam self-assigned this Jan 22, 2024
@tenthirtyam tenthirtyam added this to the v2.7.0 milestone Jan 22, 2024
@tenthirtyam tenthirtyam changed the title [fix] Add vm folder when querying for VMS fix: add vm folder when querying for vm Jan 22, 2024
@tenthirtyam tenthirtyam force-pushed the topic/vasilsatanasov/issue-1524 branch from 933adf2 to 0a29549 Compare January 22, 2024 22:04
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text case change. Otherwise looks great!

Fixes hashicorp#1524

Adding the VM folder in the search for VMs criteria in deploy from OVF
scenario.
Added e2e test. Verified that when the VM foder is not strictly
specified the OVF deploy is passing. The query is in the defautlt VM
folder.

Signed-off-by: Vasil Atanasov <[email protected]>
@vasilsatanasov vasilsatanasov force-pushed the topic/vasilsatanasov/issue-1524 branch from 0a29549 to 7da27a5 Compare January 23, 2024 06:42
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam merged commit 8313d7c into hashicorp:main Jan 23, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: error while fetching the created vm, path '<VM-NAME>' resolves to multiple vms
3 participants