-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add vm folder when querying for vm #2118
fix: add vm folder when querying for vm #2118
Conversation
933adf2
to
0a29549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor text case change. Otherwise looks great!
Fixes hashicorp#1524 Adding the VM folder in the search for VMs criteria in deploy from OVF scenario. Added e2e test. Verified that when the VM foder is not strictly specified the OVF deploy is passing. The query is in the defautlt VM folder. Signed-off-by: Vasil Atanasov <[email protected]>
0a29549
to
7da27a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Acceptance tests
Output from acceptance testing:
Release Note
References
Closes #1524