fix: scsi ids changing on machines built with v2.6.x #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the introduction of the SR-IOV feature network adapters due to inconsistent check for changes in the `physical_function` attribute have been recreated after clone since the check always returned `true`. The result is that instead of updating existing NICs the relocate tack started after clone was always deleting the existing NICs and creating new ones. This was causing the new VM to be disconnected from network Changed the check for changes in `physical_function` attribute to treat nil and empty string equaly so missing `physical_function` attribute in the device compared to empty string from the schema won't be cosnidered as changed. Testing done: cloned VM from template with 2 nics and verified that there is network connectivity. Also verified the output from lspci command on the template VM and on the clone VM. Fixes hashicorp#2089 Signed-off-by: Vasil Atanasov <[email protected]>
tenthirtyam
changed the title
iBrandyJackson
approved these changes
Jan 16, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the introduction of the SR-IOV feature network adapters due to inconsistent check for changes in the
physical_functionattribute have been recreated after clone since the check always returnedtrue. The result is that instead of updating existing NICs the relocate tack started after clone was always deleting the existing NICs and creating new ones. This was causing the new VM to be disconnected from networkChanged the check for changes in
physical_functionattribute to treat nil and empty string equaly so missingphysical_functionattribute in the device compared to empty string from the schema won't be cosnidered as changed.Testing done: cloned VM from template with 2 nics and verified that there is network connectivity. Also verified the output from lspci command on the template VM and on the clone VM.
Fixes #2089
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
#2089