fix: support asterisk in url during import

[pawelprazak]

Description

Fixes #1806 to ensure use of the correct URL parsing function from vmware/govmomi.

Testing

See #1813 (comment),

References

Closes #1806

[hashicorp-cla]

All committers have signed the CLA.

[tenthirtyam]

Could we ask that you please use conventional commits structure for the pull request title and commit description?

[pawelprazak]

Could we ask that you please use conventional commits structure for the pull request title and commit description?

I've updated the title and commit, and signed the CLA.

[pawelprazak]

@tenthirtyam could you provide any pointers regarding adding a test for this PR? :)

[tenthirtyam]

At the very least, provide the results of your ad hoc testing. cc @appilon for a e2e scenario test.

[pawelprazak]

The VM resource used for manual test:

resource "vsphere_virtual_machine" "pprazak-test-1813" {
  name             = "pprazak-test-1813"
  host_system_id   = data.vsphere_host.host.id
  resource_pool_id = data.vsphere_resource_pool.pool.id
  datastore_id     = data.vsphere_datastore.datastore.id
  datacenter_id    = data.vsphere_datacenter.dc.id

  num_cpus = 2
  memory   = 1024

  ovf_deploy {
    remote_ovf_url    = "https://cloud-images.ubuntu.com/focal/current/focal-server-cloudimg-amd64.ova"
    disk_provisioning = "thin"
  }
  network_interface {
    network_id = data.vsphere_network.network.id
  }
}

repro before the fix:

vsphere_virtual_machine.pprazak-test-1813: Creating...
╷
│ Error: error while importing ovf/ova template, error while uploading the disk ubuntu-focal-20.04-cloudimg.vmdk error while uploading the file ubuntu-focal-20.04-cloudimg.vmdk Post "https://*/ha-nfc/52e7b604-da64-267c-7dd3-bedd34f06fac/disk-0.vmdk": dial tcp: lookup *: no such host
│
│   with vsphere_virtual_machine.pprazak-test-1813,
│   on main.tf line 43, in resource "vsphere_virtual_machine" "pprazak-test-1813":
│   43: resource "vsphere_virtual_machine" "pprazak-test-1813" {

And after the fix:

vsphere_virtual_machine.pprazak-test-1813: Creating...
vsphere_virtual_machine.pprazak-test-1813: Still creating... [10s elapsed]
vsphere_virtual_machine.pprazak-test-1813: Still creating... [20s elapsed]
vsphere_virtual_machine.pprazak-test-1813: Still creating... [30s elapsed]

It made it's way to the ESXi host:

[tenthirtyam]

HI @pawelprazak - thank you for the update.

When I have some free time, I'll look over and test this pull request when I have some spare cycles..

[Djodane]

Hi ! We would love to see this PR merged to be able to deploy and manage vm from templates on standalone esxi hosts.

[tenthirtyam]

Hi ! We would love to see this PR merged to be able to deploy and manage vm from templates on standalone esxi hosts.

It will be merged once prioritized for a milestone and reviewed / approved by the maintainers.

[Djodane]

Hi ! We would love to see this PR merged to be able to deploy and manage vm from templates on standalone esxi hosts.

It will be merged once prioritized for a milestone and reviewed / approved by the maintainers.

thx! hope it'll be soon :)

[xamyp]

Hello, I would like to see these changes as well. I hope it will merge soon.

[tenthirtyam]

Hello, I would like to see these changes as well. I hope it will merge soon.

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue (Deploying local ovf directly to ESXi results in 'Error: error while importing OVF template error while uploading the file file.vmdk": dial tcp: lookup *: no such host' #1806) initial description to help the maintainers prioritize.

• Please do not leave "+1" or other comments that do not add relevant information or questions.

[tenthirtyam]

I've completed an initial verification of the change and the results are positive.

Once I perform some negative testing I'll add my review.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[tenthirtyam]

LGTM! 🚀

I've completed testing for this change and the results are all positive.

No regressions observed.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[tenthirtyam]

@iBrandyJackson I've updated the CHANGELOG.md in this pull request to reflect the changes.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

[github-actions]

This functionality has been released in v2.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.