Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update resource/virtual_machine #1563

Merged
merged 1 commit into from
Oct 16, 2023
Merged

docs: update resource/virtual_machine #1563

merged 1 commit into from
Oct 16, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Jan 26, 2022

Description

Updated resource/virtual_machine docs for:

  • sync_time_with_host
  • sync_time_with_host_periodically

Additional reference: https://kb.vmware.com/s/article/1189

VMware Tools performs two types of time corrections:

One-off time sync: Guest system clock is synchronized to host time upon specific VM life-cycle events that can cause guest** clock to become incorrect, such as resuming from vMotion or a snapshot. This capability is recommended for use and turned ON by default.

Periodic time sync: Guest system clock is periodically (every 60 seconds) synchronized to track host time. It is recommended that guests use a native time synchronization service – such as NTPD or Chrony in Linux based operating systems, and W32Time for Microsoft Windows. If that's not viable, periodic time sync provides an alternative. This capability is turned OFF by default.

This has been confirmed with VMware engineering "time-lords".

Release Note

References

@tenthirtyam tenthirtyam requested a review from appilon January 26, 2022 23:22
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small labels Jan 26, 2022
@tenthirtyam tenthirtyam added breaking-change Status: Breaking Change bug Type: Bug vsphere/v7 vSphere 7.0 and removed documentation Type: Documentation size/xs Relative Sizing: Extra-Small provider Type: Provider labels Jan 26, 2022
@tenthirtyam tenthirtyam self-assigned this Feb 3, 2022
@tenthirtyam tenthirtyam added documentation Type: Documentation planned labels Feb 3, 2022
@tenthirtyam tenthirtyam assigned appilon and unassigned tenthirtyam Feb 10, 2022
@tenthirtyam tenthirtyam added this to the v3.0.0 milestone Feb 14, 2022
@tenthirtyam tenthirtyam added the area/vm Area: Virtual Machines label Feb 22, 2022
@tenthirtyam tenthirtyam changed the title Update sync_time_with_host to default to true fix: Update sync_time_with_host to default to true Mar 11, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@tenthirtyam tenthirtyam added the merge-conflict Merge Conflict label Sep 11, 2022
@tenthirtyam tenthirtyam marked this pull request as draft September 11, 2022 21:52
@github-actions github-actions bot added provider Type: Provider size/xs Relative Sizing: Extra-Small labels Sep 11, 2022
@tenthirtyam tenthirtyam removed the merge-conflict Merge Conflict label Sep 11, 2022
@tenthirtyam tenthirtyam assigned tenthirtyam and unassigned appilon Aug 7, 2023
@github-actions github-actions bot removed the provider Type: Provider label Oct 15, 2023
VMware recommends that `sync_time_with_host` to default to `true`.

Closes #1443

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam removed the bug Type: Bug label Oct 15, 2023
@tenthirtyam tenthirtyam removed the breaking-change Status: Breaking Change label Oct 15, 2023
@tenthirtyam tenthirtyam modified the milestones: v3.0.0, v2.6.0 Oct 15, 2023
@tenthirtyam tenthirtyam changed the title fix: Update sync_time_with_host to default to true docs: update resource/virtual_machine Oct 15, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review October 15, 2023 22:49
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 15, 2023 22:49
@tenthirtyam tenthirtyam removed the request for review from appilon October 16, 2023 13:29
@tenthirtyam tenthirtyam merged commit f48cce8 into hashicorp:main Oct 16, 2023
3 checks passed
@tenthirtyam tenthirtyam deleted the gh-1443 branch October 16, 2023 19:46
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
@hashicorp hashicorp unlocked this conversation Nov 30, 2023
Copy link

This functionality has been released in v2.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/vm Area: Virtual Machines documentation Type: Documentation size/xs Relative Sizing: Extra-Small vsphere/v7 vSphere 7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants