fix: Update vsphere_content_library defaults for subscribed libraries
#1502
Conversation
github-actions
bot
added
documentation
| @@ -113,13 +113,13 @@ func resourceVSphereContentLibrary() *schema.Resource { | |||
| Type: schema.TypeBool, | |||
| ForceNew: true, | |||
| Optional: true, | |||
| Default: true, | |||
| Default: false, | |||
There was a problem hiding this comment.
I will have to brush up on the subtleties of this situation, I also don't have full context on the provider/product yet, but this change could be perceived as a breaking change?
What happens to users who had both this field and automatic_sync unset?
There was a problem hiding this comment.
As I recall, it will default to on_demand still.
Yes, it could be perceived as a breaking change, but the current experience is opposite of the product defaults.
Happy to help in any way - message me, if needed.
Ryan
|
Let me know if you have any additional question @appilon - happy to review over Zoom, too. :) |
github-actions
bot
added
size/xs
tenthirtyam
changed the title
vsphere_content_library defaults for subscribed librariesvsphere_content_library defaults for subscribed libraries
|
|
|
Converted to draft to avoid accidental merge before next major. Ryan Johnson |
Addresses #1426 by @tenthirtyam. - Sets `automatic_sync` as `Default: true` to align with the default behavior in the vSphere UI. Sets `on_demand` as `Default: false` - Updates the content of the documentation - `content_library.html.markdown` - for readability, context, and accuracy. - Updates the content of the documentation - `content_library.html.markdown` - with subscribed library example. Signed-off-by: Ryan Johnson <[email protected]>
- Update subscribed content library example. - Update examples to use `storage_backing = toset([data.vsphere_datastore.datastore.id])` as a set is required. Addresses #1351. Signed-off-by: Ryan Johnson <[email protected]>
Updates the examples to use `storage_backing = toset([data.vsphere_datastore.datastore.id])` as a set is required. Signed-off-by: Ryan Johnson <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
automatic_syncasDefault: trueto align with the default behavior in the vSphere UI. Setson_demandasDefault: falseAcceptance tests
None. Performed a
go getandgo buildto perform positive and negative unit tests.Release Note
resource/vsphere_content_library: Setsautomatic_syncasDefault: trueon a subscribed content library to align with the default behavior in the vSphere UI. Setson_demandasDefault: false[fix: Updatevsphere_content_librarydefaults for subscribed libraries #1502]resource/vsphere_content_library: Updates resource documentation example forstorage_backingattribute. [fix: Updatevsphere_content_librarydefaults for subscribed libraries #1502]References
Resolves #1426 by @tenthirtyam.