Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_standard - site_config.min_tls_version and site_config. scm_min_tls_version no longer accept 1.0 or 1.1 as a value in 5.0. #28229

Merged
merged 1 commit into from
Dec 10, 2024
+26 −4
Merged

azurerm_logic_app_standard - site_config.min_tls_version and site_config. scm_min_tls_version no longer accept 1.0 or 1.1 as a value in 5.0. #28229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions internal/services/logic/logic_app_standard_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,8 +793,6 @@ func schemaLogicAppStandardSiteConfig() *pluginsdk.Schema {
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{
string(webapps.SupportedTlsVersionsOnePointZero),
string(webapps.SupportedTlsVersionsOnePointOne),
string(webapps.SupportedTlsVersionsOnePointTwo),
}, false),
},
Expand All @@ -819,8 +817,6 @@ func schemaLogicAppStandardSiteConfig() *pluginsdk.Schema {
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{
string(webapps.SupportedTlsVersionsOnePointZero),
string(webapps.SupportedTlsVersionsOnePointOne),
string(webapps.SupportedTlsVersionsOnePointTwo),
}, false),
},
Expand Down Expand Up @@ -917,6 +913,26 @@ func schemaLogicAppStandardSiteConfig() *pluginsdk.Schema {
Computed: true,
Deprecated: "the `site_config.public_network_access_enabled` property has been superseded by the `public_network_access` property and will be removed in v5.0 of the AzureRM Provider.",
}
schema.Elem.(*pluginsdk.Resource).Schema["scm_min_tls_version"] = &pluginsdk.Schema{
Type: pluginsdk.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{
string(webapps.SupportedTlsVersionsOnePointZero),
string(webapps.SupportedTlsVersionsOnePointOne),
string(webapps.SupportedTlsVersionsOnePointTwo),
}, false),
}
schema.Elem.(*pluginsdk.Resource).Schema["min_tls_version"] = &pluginsdk.Schema{
Type: pluginsdk.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{
string(webapps.SupportedTlsVersionsOnePointZero),
string(webapps.SupportedTlsVersionsOnePointOne),
string(webapps.SupportedTlsVersionsOnePointTwo),
}, false),
}
}

return schema
Expand Down
2 changes: 2 additions & 0 deletions website/docs/5.0-upgrade-guide.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ Please follow the format in the example below for listing breaking changes in re
### `azurerm_logic_app_standard`

* The deprecated `site_config.public_network_access_enabled` property has been removed and superseded by the `public_network_access` property.
* The `site_config.min_tls_version` property no longer accepts `1.0` or `1.1` as a value.
* The `site_config.scm_min_tls_version` property no longer accepts `1.0` or `1.1` as a value.

### `azurerm_monitor_aad_diagnostic_setting`

Expand Down
4 changes: 4 additions & 0 deletions website/docs/r/logic_app_standard.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,16 @@ The `site_config` block supports the following:

* `scm_min_tls_version` - (Optional) Configures the minimum version of TLS required for SSL requests to the SCM site. Possible values are `1.0`, `1.1` and `1.2`.

~> **Note** Azure Services will require TLS 1.2+ by August 2025, please see this [announcement](https://azure.microsoft.com/en-us/updates/v2/update-retirement-tls1-0-tls1-1-versions-azure-services/) for more.

* `scm_type` - (Optional) The type of Source Control used by the Logic App in use by the Windows Function App. Defaults to `None`. Possible values are: `BitbucketGit`, `BitbucketHg`, `CodePlexGit`, `CodePlexHg`, `Dropbox`, `ExternalGit`, `ExternalHg`, `GitHub`, `LocalGit`, `None`, `OneDrive`, `Tfs`, `VSO`, and `VSTSRM`

* `linux_fx_version` - (Optional) Linux App Framework and version for the App Service, e.g. `DOCKER|(golang:latest)`. Setting this value will also set the `kind` of application deployed to `functionapp,linux,container,workflowapp`

* `min_tls_version` - (Optional) The minimum supported TLS version for the Logic App. Possible values are `1.0`, `1.1`, and `1.2`. Defaults to `1.2` for new Logic Apps.

~> **Note** Azure Services will require TLS 1.2+ by August 2025, please see this [announcement](https://azure.microsoft.com/en-us/updates/v2/update-retirement-tls1-0-tls1-1-versions-azure-services/) for more.

* `pre_warmed_instance_count` - (Optional) The number of pre-warmed instances for this Logic App Only affects apps on the Premium plan.

* `runtime_scale_monitoring_enabled` - (Optional) Should Runtime Scale Monitoring be enabled?. Only applicable to apps on the Premium plan. Defaults to `false`.
Expand Down
Loading