new resource azurerm_arc_kubernetes_provisioned_cluster

[teowa]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

supersede #26916

reference:

• azure doc: part of the https://learn.microsoft.com/en-us/azure/aks/hybrid/aks-create-clusters-portal
• swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hybridkubernetes/resource-manager/Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json
• verified module: https://github.com/Azure/terraform-azurerm-avm-res-hybridcontainerservice-provisionedclusterinstance/blob/d8b6827252319e66d1d722dba217714d6cf85484/main.tf#L28-L78

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

TF_ACC=1 go test -v ./internal/services/arckubernetes -parallel 5 -run TestAccArcKubernetesProvisionedCluster_ -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccArcKubernetesProvisionedCluster_basic
=== PAUSE TestAccArcKubernetesProvisionedCluster_basic
=== RUN   TestAccArcKubernetesProvisionedCluster_requiresImport
=== PAUSE TestAccArcKubernetesProvisionedCluster_requiresImport
=== RUN   TestAccArcKubernetesProvisionedCluster_update
=== PAUSE TestAccArcKubernetesProvisionedCluster_update
=== RUN   TestAccArcKubernetesProvisionedCluster_complete
=== PAUSE TestAccArcKubernetesProvisionedCluster_complete
=== CONT  TestAccArcKubernetesProvisionedCluster_basic
=== CONT  TestAccArcKubernetesProvisionedCluster_complete
=== CONT  TestAccArcKubernetesProvisionedCluster_update
=== CONT  TestAccArcKubernetesProvisionedCluster_requiresImport
--- PASS: TestAccArcKubernetesProvisionedCluster_requiresImport (201.58s)
--- PASS: TestAccArcKubernetesProvisionedCluster_basic (208.31s)
--- PASS: TestAccArcKubernetesProvisionedCluster_complete (219.30s)
--- PASS: TestAccArcKubernetesProvisionedCluster_update (376.70s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/arckubernetes 376.727s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Resource azurerm_arc_kubernetes_provisioned_cluster

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Overall this looks good @teowa! Would you mind fixing up the two minor comments while the tests are running? Once that's done and the tests are green this should be good to go.

[stephybun]

Please be mindful of the ordering here

Suggested change

	client := metadata.Client.ArcKubernetes.ArcKubernetesClient
	var model ArcKubernetesProvisionedClusterModel
	if err := metadata.Decode(&model); err != nil {
	return fmt.Errorf("decoding: %+v", err)
	}
	subscriptionId := metadata.Client.Account.SubscriptionId
	client := metadata.Client.ArcKubernetes.ArcKubernetesClient
	subscriptionId := metadata.Client.Account.SubscriptionId
	var model ArcKubernetesProvisionedClusterModel
	if err := metadata.Decode(&model); err != nil {
	return fmt.Errorf("decoding: %+v", err)
	}

[teowa]

fixed

[stephybun]

Suggested change

	Identity: *expandedIdentity,
	Identity: pointer.To(expandedIdentity),

[teowa]

Fixed, this should be pointer.From(expandedIdentity)

[stephybun]

We might want to increase this since the tests fail with

------- Stdout: -------
=== RUN   TestAccArcKubernetesProvisionedCluster_basic
=== PAUSE TestAccArcKubernetesProvisionedCluster_basic
=== CONT  TestAccArcKubernetesProvisionedCluster_basic
    testcase.go:173: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: deleting Connected Cluster (Subscription: "*******"
        Resource Group Name: "acctestRG-akpc-241209123533880988"
        Connected Cluster Name: "acctest-akpc-241209123533880988"): polling after ConnectedClusterDelete: context deadline exceeded