Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - updated cdn_frontdoor_origin_group docs to reflect valid health probe intervals #28143

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

bubbletroubles
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Docs - updated cdn_frontdoor_origin_group docs to reflect valid health probe intervals. Specifying a value larger than 255 gives the error

│ Error: creating Front Door Origin Group: (Origin Group Name "<name>" / Profile Name "<name>" / Resource Group "<name>"): cdn.AFDOriginGroupsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Property 'AfdOriginGroup.HealthProbeSettings.ProbeIntervalInSeconds' cannot be set to '300'. Acceptable values are within range [1, 255]"

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • cdn_frontdoor_origin_group - updated docs to reflect valid values for interval_in_seconds property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change
  • Documentation

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@bubbletroubles bubbletroubles marked this pull request as ready for review November 30, 2024 00:28
@bubbletroubles bubbletroubles requested a review from a team as a code owner November 30, 2024 00:28
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bubbletroubles the validation for the property still allows values higher than 255, could you update that as well?

"interval_in_seconds": {
Type: pluginsdk.TypeInt,
Required: true,
ValidateFunc: validation.IntBetween(5, 31536000),
},

@bubbletroubles
Copy link
Contributor Author

Thanks @stephybun . That's been updated now.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bubbletroubles LGTM 👍

@stephybun stephybun added the bug label Dec 2, 2024
@stephybun stephybun merged commit b240052 into hashicorp:main Dec 2, 2024
33 checks passed
@github-actions github-actions bot added this to the v4.13.0 milestone Dec 2, 2024
stephybun added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants