Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_data_export_rule - wait for state after creation #27876

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Nov 4, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The service might return 404 for newly created azurerm_log_analytics_data_export_rule, and it requires an additional polling to make sure we do not get 404 response. tracked on Azure/azure-rest-api-specs#31399

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image ## Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added size/S and removed size/XS labels Nov 5, 2024
@ziyeqf ziyeqf marked this pull request as ready for review November 5, 2024 02:31
@ziyeqf ziyeqf requested review from katbyte and a team as code owners November 5, 2024 02:31
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ziyeqf thanks for submitting this, however we have moved away from using StateRefreshFuncs now and are now implementing custom pollers to do this instead. Would you be able to re-work this to use a custom poller instead? You can find an example of one here. Thanks!

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Dec 12, 2024

sorry for the delay, updated

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Dec 12, 2024

new test result:
image

@ziyeqf ziyeqf requested a review from catriona-m December 13, 2024 02:16
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the poller @ziyeqf - I just left one query on this but otherwise this is looking good. Thanks!


func (p LogAnalyticsDataExportPoller) Poll(ctx context.Context) (*pollers.PollResult, error) {
resp, err := p.client.Get(ctx, p.id)
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a provisioning state returned that we could use here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants