-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_log_analytics_data_export_rule
- wait for state after creation
#27876
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the poller @ziyeqf - I just left one query on this but otherwise this is looking good. Thanks!
|
||
func (p LogAnalyticsDataExportPoller) Poll(ctx context.Context) (*pollers.PollResult, error) { | ||
resp, err := p.client.Get(ctx, p.id) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a provisioning state returned that we could use here?
Community Note
Description
The service might return 404 for newly created
azurerm_log_analytics_data_export_rule
, and it requires an additional polling to make sure we do not get 404 response. tracked on Azure/azure-rest-api-specs#31399PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_log_analytics_data_export_rule
- wait for state after creation [azurerm_log_analytics_data_export_rule
- wait for state after creation #27876]This is a (please select all that apply):
Related Issue(s)
Note
If this PR changes meaningfully during the course of review please update the title and description as required.