-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appconfiguration
- avoid replace in update test
#27415
base: main
Are you sure you want to change the base?
Conversation
appconfiguration
- avoid replace in updateappconfiguration
- test: avoid replace in update
appconfiguration
- test: avoid replace in updateappconfiguration
- avoid replace in update test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failed test should be related to App Config REST API Real-time consistency,
This makes App Config tests fail occasionally, but this might not affect users since the sync-time is only few seconds, which should be less than the normal operation refresh gaps. |
this is still a bug in the provider thou? we should handle it by add code to read a few times in a row until we get a the correct value much like we do in azuread and other other resources? |
@@ -81,3 +83,61 @@ func appConfigurationGetKeyRefreshFunc(ctx context.Context, client *appconfigura | |||
return res, "Exists", nil | |||
} | |||
} | |||
|
|||
func appConfigurationGetKeyRefreshFuncForUpdate(ctx context.Context, client *appconfiguration.BaseClient, key, label string, model appconfiguration.KeyValue) pluginsdk.StateRefreshFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added to ensure the App Config Key/Feature property is fully synced after an update.
…m into fix_appconf_test_replace
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
appconfiguration
- avoid replace in updateThis is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.