azurerm_[linux|windows]_virtual_machine_scale_set - support for os_image_notification property

[mouellet]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add the os_image_notification property to azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set. When enabled, this will enable a notification to be sent to the VM on the instance metadata server that a VM is undergoing an operation on the OS image, such as a reimage or an OS update.

Reuse the schema and logic of azurerm_[linux|windows]_virtual_machine from #23394.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

TF_ACC=1 go test -v ./internal/services/compute -run=TestAccLinuxVirtualMachineScaleSet_otherOsImageNotification -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxVirtualMachineScaleSet_otherOsImageNotification
=== PAUSE TestAccLinuxVirtualMachineScaleSet_otherOsImageNotification
=== CONT  TestAccLinuxVirtualMachineScaleSet_otherOsImageNotification
--- PASS: TestAccLinuxVirtualMachineScaleSet_otherOsImageNotification (306.56s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       306.583s

TF_ACC=1 go test -v ./internal/services/compute -run=TestAccWindowsVirtualMachineScaleSet_otherOsImageNotification -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsVirtualMachineScaleSet_otherOsImageNotification
=== PAUSE TestAccWindowsVirtualMachineScaleSet_otherOsImageNotification
=== CONT  TestAccWindowsVirtualMachineScaleSet_otherOsImageNotification
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherOsImageNotification (382.55s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       382.578s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_[linux|windows]_virtual_machine_scale_set - support for os_image_notification property

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[nicolasShs]

@rcskosir Hi do you have any estimates when these changes can be pushed forward? Or do we have any workarounds for now?

[nicolasShs]

Hi @katbyte
Any updates?