Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_container_registry_cache_rule #26034

Merged
merged 74 commits into from
May 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
9a7b309
Add an SDK client for Cache Rules
mhaligowski Nov 27, 2023
f5d817b
Synch vendor directory
mhaligowski Nov 27, 2023
abb4211
Generate parser and validator
mhaligowski Nov 27, 2023
65cdac2
Verify the name of the cache rule
mhaligowski Nov 27, 2023
f122449
Fix the vendor versions
mhaligowski Nov 27, 2023
9441261
Fix the vendor versions
mhaligowski Nov 27, 2023
e30a431
Create and Read
mhaligowski Nov 27, 2023
c9066b3
add registration and dummy test
mhaligowski Nov 28, 2023
cd96b0a
Adjust for the correct layout
mhaligowski Dec 11, 2023
b382672
Fix the vendor versions
npk-amperon May 20, 2024
4d6bf92
remove unnecessary test
npk-amperon May 20, 2024
60fe246
feat: use container_registry_id as arg
npk-amperon May 20, 2024
be8ecd5
feat: return cacherules
npk-amperon May 20, 2024
8a93ba3
fix: formatting
npk-amperon May 20, 2024
876320e
fix: test and deps
npk-amperon May 20, 2024
b0718b1
more test fixes
npk-amperon May 20, 2024
6bba7a2
feat: improve registry ID parsing for cache resource
npk-amperon May 20, 2024
03e8319
feat: add docs for cache rule resource
npk-amperon May 20, 2024
b23458a
fix: cache rule resource docs
npk-amperon May 20, 2024
4ef3cf7
fix: typo
npk-amperon May 20, 2024
4cc5162
feat: add support for CredentialSetId
npk-amperon May 21, 2024
670fafa
fix: docs
npk-amperon May 21, 2024
54e09e4
feat: add container_registry_cache_rule data source, as well as name …
npk-amperon May 21, 2024
3b19cab
feat: add container_registry_cache_rule data source docs
npk-amperon May 21, 2024
254299a
fix: formatting
npk-amperon May 21, 2024
6a9980f
Update internal/services/containers/client/client.go
npk-amperon May 28, 2024
5bda934
Update internal/services/containers/client/client.go
npk-amperon May 28, 2024
04a24a2
Update internal/services/containers/client/client.go
npk-amperon May 28, 2024
838cd69
Update internal/services/containers/client/client.go
npk-amperon May 28, 2024
62b94ff
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
eac13e8
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
aa880f5
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
81ad620
Update internal/services/containers/resourceids.go
npk-amperon May 28, 2024
d92a877
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
c1b0667
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
8fe8f9e
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
497ee73
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
87c2f27
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
bbb1065
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
080a4a5
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
7cf6ab3
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
a6f4d03
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
ddec6db
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
318ce10
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
9469850
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 28, 2024
251b135
feat: update go dep files
npk-amperon May 28, 2024
32c76f8
feat: use model struct for container_registry_cache_rule resource
npk-amperon May 28, 2024
02f0a2d
feat: validate credential set id
npk-amperon May 28, 2024
626a993
Update internal/services/containers/container_registry_cache_rule_dat…
npk-amperon May 28, 2024
1f54be6
fix: vendor and formatting updates for cache_rule
npk-amperon May 28, 2024
c1266b3
feat: use model encoding/decoding for cache rule resource
npk-amperon May 28, 2024
ee45bef
feat: use CustomizeDiff to force rebuild and container registry updat…
npk-amperon May 28, 2024
0172fc6
fix: typo in resource diff logic for cache rule resource
npk-amperon May 29, 2024
e5a4c8f
feat: update cache rule name regex, and add unit tests
npk-amperon May 29, 2024
1242f54
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
d54c215
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
cbc86fd
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
a53e585
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
c8001df
Update website/docs/r/container_registry_cache_rule.html.markdown
npk-amperon May 29, 2024
1ed9e84
Update website/docs/r/container_registry_cache_rule.html.markdown
npk-amperon May 29, 2024
589352f
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
40e7c02
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 29, 2024
b96bc19
fix: remove unused files for cache rule
npk-amperon May 29, 2024
f641de6
feat: remove obsolete TODO comments from cache rule resource
npk-amperon May 29, 2024
b4e6f88
fix: update go deps
npk-amperon May 29, 2024
3f6ae05
fix: linting and vendor modules
npk-amperon May 29, 2024
827c7d3
fix: reinitialization of cache rule context
npk-amperon May 29, 2024
0b7520e
fix: update vendor
npk-amperon May 29, 2024
69448a8
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 30, 2024
673946b
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 30, 2024
f3a0ffa
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 30, 2024
bf6bdea
Update internal/services/containers/container_registry_cache_rule_res…
npk-amperon May 30, 2024
51199ef
fix: remove unused import
npk-amperon May 30, 2024
4f0806e
fix: fmt
npk-amperon May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update internal/services/containers/container_registry_cache_rule_res…
…ource.go

Co-authored-by: stephybun <[email protected]>
  • Loading branch information
npk-amperon and stephybun committed May 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 589352fad20f2ecf50e9e152b2f722f4e983486a
Original file line number Diff line number Diff line change
@@ -182,9 +182,8 @@ func (ContainerRegistryCacheRule) Read() sdk.ResourceFunc {
return fmt.Errorf("retrieving %s: %+v", *id, err)
}

registryIdString := registryId.ID()
config.Name = pointer.From(&id.CacheRuleName)
config.ContainerRegistryId = pointer.From(&registryIdString)
config.Name = id.CacheRuleName
config.ContainerRegistryId = registryId.ID()

if model := resp.Model; model != nil {
if properties := model.Properties; properties != nil {