-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User(s) Data Source: Lookup users by on-prem SAM account #707
base: main
Are you sure you want to change the base?
Conversation
Random integer as an onpremises_immutable_id It is done the same way for the "complete" use-case "test" user
In Data Sources: User and Users documentation
Tests on User and Users Data Sources, for validating support of on-prem SAM account names as reference arguments. Data source should be able to search users by on-prem SAM account name, the same way it's possible than by UPN or mail nickname.
0a5b82e
to
8a83fcb
Compare
- Refactor of DS Read method for both data sources. - User and Users data sources to support specifying `onpremises_sam_account_name`(s) respectively, as a search argument when looking up users. - Users data source also exports onpremises_sam_account_names
8a83fcb
to
a464f8c
Compare
Hi @daramir, many thanks for working on this! This is definitely a feature we'd like to add, although at this time we don't have a way to test this. I'm looking at improving our testing setup to include a tenant with AD Connect and once this is done, we'll be in a position to look at merging this. |
@manicminer what's the timeline on testing improvements? |
Hi @manicminer , just checking in to echo Patrick's question. Do you have a broad timeline for the testing setup with AD connect? Kind regards |
We don't have a timeline at the moment, my best guess with current priorities is in the order of several weeks. Once we have a workable test environment I'll get back on this straight away. |
Hi @manicminer , could you please provide us with an updated timeline for the test env to be set up? |
Hey @manicminer, just following up on the current state of this... |
@manicminer giving this one a bump... |
This PR extends the features on User and Users Data Sources, by adding support to look up users by on-premise SAM account name.
SAM account names as reference arguments.
Data source should be able to search users by on-prem SAM account name, the same way it's possible than by UPN or
mail nickname.
Note: Haven't confirmed the status of the tests, please advice if correct and complete. The value for the on-prem SAM account name for the test users is unknown to me.