Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azuread_user: support employee hire date #1437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

azuread_user: support employee hire date #1437

wants to merge 1 commit into from

Conversation

kang8
Copy link

@kang8 kang8 commented Jul 17, 2024

Closed: #1436

@kang8 kang8 force-pushed the feature/user-support-employee-hire-date branch from 9840450 to 4ea9c40 Compare September 12, 2024 10:01
@kang8
Copy link
Author

kang8 commented Sep 12, 2024

Hi @manicminer, Can you please take a look when you have a chance?

The code has been tested on my end.

@Threpio
Copy link
Contributor

Threpio commented Oct 4, 2024

Code looks good from me too (if that matters)

Just curious as to whether the time that is passed to Microsoft has to include the Hour, Minute and Second part or if it can be just a date?

@kang8
Copy link
Author

kang8 commented Oct 8, 2024

Just curious as to whether the time that is passed to Microsoft has to include the Hour, Minute and Second part or if it can be just a date?

This is very interesting.

From the perspective of the API, it can specify hours, minutes and seconds.

image

But on the UI, it can only be a date.

image

@kang8 kang8 force-pushed the feature/user-support-employee-hire-date branch from 4ea9c40 to c727d3d Compare October 23, 2024 09:51
@kang8 kang8 requested review from katbyte and a team as code owners October 23, 2024 09:51
@kang8 kang8 marked this pull request as draft October 23, 2024 09:53
@kang8
Copy link
Author

kang8 commented Oct 23, 2024

Switch this PR to draft for now. After rebasing to the latest master, I noticed significant changes in the code structure. I will mark it as ready once I've finished making the necessary adjustments.

@kang8 kang8 force-pushed the feature/user-support-employee-hire-date branch from c727d3d to 448a6cf Compare November 5, 2024 09:56
@kang8 kang8 marked this pull request as ready for review November 5, 2024 09:58
@kang8
Copy link
Author

kang8 commented Nov 5, 2024

Hi @katbyte, I marked it as ready for this PR, and the code has been tested on my end.

Can you please take a look?

jackofallops
jackofallops requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kang8 - Just one minor change needed, then I think this will be good to go.

Thanks

docs/resources/user.md Outdated Show resolved Hide resolved
@kang8
Copy link
Author

kang8 commented Nov 5, 2024 •
edited
Loading

@jackofallops thanks for your review, I've applied the patch.

@kang8 kang8 force-pushed the feature/user-support-employee-hire-date branch from e7d45e8 to e7a5ecb Compare November 6, 2024 01:45
@kang8 kang8 requested a review from jackofallops November 6, 2024 01:49
@kang8
Copy link
Author

kang8 commented Nov 8, 2024

Hi @jackofallops, could you please take another look when you have a moment? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte Awaiting requested review from katbyte

@jackofallops jackofallops Awaiting requested review from jackofallops

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation feature/users size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azuread_user: support employee hire date
3 participants
@kang8 @Threpio @jackofallops