Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs - awscc_cloudfront_distribution #977

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs - awscc_cloudfront_distribution #977

wants to merge 2 commits into from

Conversation

pkrishjobs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates OR Closes #0000

wellsiau-aws
wellsiau-aws suggested changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out what's going on with the OAI/OAC after apply before we merge this

templates/resources/cloudfront_distribution.md.tmpl Outdated

{{ tffile (printf "examples/resources/%s/cloudfront_with_s3_origin_oai.tf" .Name)}}

## NOTE: After successful resource creation, edit the Cloufront Origin, origin access from default public setting to use either the OAC or OAI which were created
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a problem upstream on the handler , please open a Github issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - Issue logged - #983 (comment)

@pkrishjobs pkrishjobs mentioned this pull request Jun 9, 2023
Open
wellsiau-aws
wellsiau-aws reviewed Jun 12, 2023
View reviewed changes
templates/resources/cloudfront_distribution.md.tmpl Outdated

{{ tffile (printf "examples/resources/%s/cloudfront_with_s3_origin_oai.tf" .Name)}}

## NOTE: After successful resource creation, edit the Cloufront Origin, origin access from default public setting to use either the OAC or OAI which were created
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this note, we expect the issue to be resolved upstream and hold the merge until then

wellsiau-aws
wellsiau-aws suggested changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the note, and we'll hold up the merge until issue #983 is triaged

@pkrishjobs
Copy link
Contributor Author

Note added part of the documentation for workaround was removed and PR updated with changes. Awaiting resolution on Issue#983 before merging the PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wellsiau-aws wellsiau-aws wellsiau-aws requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation examples service/cloudfront waiting-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkrishjobs @wellsiau-aws @ewbankkit