Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-12-05 Schema Updates #2120

Merged
merged 8 commits into from
Dec 5, 2024
Merged

2024-12-05 Schema Updates #2120

merged 8 commits into from
Dec 5, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 5, 2024

Description

CloudFormation schema updates as of 2024-12-05.

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_'
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 20 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m

2024-12-05T14:07:26.089-0500 [ERROR] sdk.proto: Response contains error diagnostic: tf_req_id=30516e2e-9b1d-06b5-0b71-937abd4bb649 tf_rpc=ReadDataSource tf_data_source_type=awscc_logs_log_group tf_provider_addr=registry.terraform.io/hashicorp/awscc diagnostic_summary="AWS Data Source Not Found" diagnostic_detail="After attempting to read the data source, the API returned a resource not found error for the id provided. Original Error: couldn't find resource" diagnostic_severity=ERROR tf_proto_version=6.7
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (1.01s)
--- PASS: TestAccAWSLogsLogGroup_basic (23.68s)
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (23.83s)
--- PASS: TestAccAWSLogsLogGroup_disappears (29.10s)
--- PASS: TestAccAWSLogsLogGroup_update (31.02s)
PASS
ok      github.com/hashicorp/terraform-provider-awscc/internal/aws/logs 31.837s

@jar-b jar-b requested a review from a team as a code owner December 5, 2024 19:08
@quixoticmonk
Copy link
Collaborator

quixoticmonk commented Dec 5, 2024

Is the AWS::SageMaker::Cluster schema still excluded from the refresh ? The CustomMetadata property which was present on the last schema ( which caused it to be excluded from schema pull) was removed by the service team.

@jar-b
Copy link
Member Author

jar-b commented Dec 5, 2024

I'll take a look and see if we can re-generate without issue now.

@jar-b jar-b marked this pull request as draft December 5, 2024 19:30
@jar-b
Copy link
Member Author

jar-b commented Dec 5, 2024

Smoke tests still passing after removing suppression for AWS SageMaker cluster schema changes.

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_'
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 20 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m

2024-12-05T15:11:30.924-0500 [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_severity=ERROR tf_data_source_type=awscc_logs_log_group tf_req_id=46c1ae9b-0cb8-6a11-dd1d-9767c79eabb3 tf_provider_addr=registry.terraform.io/hashicorp/awscc tf_proto_version=6.7 tf_rpc=ReadDataSource diagnostic_summary="AWS Data Source Not Found" diagnostic_detail="After attempting to read the data source, the API returned a resource not found error for the id provided. Original Error: couldn't find resource"
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (0.98s)
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (21.14s)
--- PASS: TestAccAWSLogsLogGroup_basic (26.20s)
--- PASS: TestAccAWSLogsLogGroup_disappears (26.67s)
--- PASS: TestAccAWSLogsLogGroup_update (34.23s)
PASS
ok      github.com/hashicorp/terraform-provider-awscc/internal/aws/logs 35.243

@jar-b jar-b marked this pull request as ready for review December 5, 2024 20:14
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit c8bc35d into main Dec 5, 2024
11 checks passed
@jar-b jar-b deleted the f-2024-12-05-schema-updates branch December 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants