Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-30-2024 Schema Updates #2085

Merged
merged 6 commits into from
Oct 31, 2024
Merged

10-30-2024 Schema Updates #2085

merged 6 commits into from
Oct 31, 2024

Conversation

johnsonaj
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.
% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_'

TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 20 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_update
=== CONT  TestAccAWSLogsLogGroup_disappears
2024-10-30T16:58:24.806-0500 [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_detail="After attempting to read the data source, the API returned a resource not found error for the id provided. Original Error: couldn't find resource" diagnostic_severity=ERROR diagnostic_summary="AWS Data Source Not Found" tf_proto_version=6.6 tf_rpc=ReadDataSource tf_data_source_type=awscc_logs_log_group tf_req_id=75030f1b-6c14-57ac-e798-5c149c9f9048 tf_provider_addr=registry.terraform.io/hashicorp/awscc
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (1.23s)
--- PASS: TestAccAWSLogsLogGroup_basic (23.93s)
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (24.51s)
--- PASS: TestAccAWSLogsLogGroup_disappears (27.37s)
--- PASS: TestAccAWSLogsLogGroup_update (36.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	37.433s

@johnsonaj johnsonaj marked this pull request as ready for review October 30, 2024 22:20
@johnsonaj johnsonaj requested a review from a team as a code owner October 30, 2024 22:20
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit cd5e1a5 into main Oct 31, 2024
14 checks passed
@johnsonaj johnsonaj deleted the f-10-30-2024-schema-updates branch October 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants