Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change provider docs assume_role to be list instead of object #2040

Closed
wants to merge 4 commits into from

Conversation

akozhuharov
Copy link

@akozhuharov akozhuharov commented Sep 27, 2024

As per this commit the behaviour is changed from object to list

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates #2029.

@akozhuharov akozhuharov requested a review from a team as a code owner September 27, 2024 09:28
@gdavison
Copy link
Contributor

Thanks for this PR, @akozhuharov. The change in assume_role was a breaking change (see #2041), so we will be rolling it back in #2043. We will reintroduce IAM role chaining in a future release.

Since we're rolling back this change, the documentation changes will not be needed. Thanks again for the PR

@gdavison gdavison closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants