Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsuppress: awscc_events_connection #2001

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

wellsiau-aws
Copy link
Collaborator

Resource awscc_events_connection was previously suppressed due to problem with undefined writeOnlyProperties. The recent schema update has resolved the problem.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates #1521

@wellsiau-aws
Copy link
Collaborator Author

Test Create

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # awscc_events_connection.pagerduty_connection will be created
  + resource "awscc_events_connection" "pagerduty_connection" {
      + arn                = (known after apply)
      + auth_parameters    = {
          + api_key_auth_parameters    = {
              + api_key_name  = "Authorization"
              + api_key_value = "my-secret-string"
            }
          + basic_auth_parameters      = (known after apply)
          + invocation_http_parameters = (known after apply)
          + o_auth_parameters          = (known after apply)
        }
      + authorization_type = "API_KEY"
      + description        = (known after apply)
      + id                 = (known after apply)
      + name               = "pagerduty-connection"
      + secret_arn         = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.
awscc_events_connection.pagerduty_connection: Creating...
awscc_events_connection.pagerduty_connection: Creation complete after 6s [id=pagerduty-connection]

@wellsiau-aws
Copy link
Collaborator Author

not sure why the singular data source docs was not generated, investigating

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit 051ffa1 into hashicorp:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants