Support resources with top-level Id property that isn't the primaryIdentifier
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Terraform attribute name.
This reverts commit 5c08694.
% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/ec2 TESTARGS='-run=TestAccAWSEC2EgressOnlyInternetGateway_success' TF_ACC=1 go test ./internal/aws/ec2 -v -count 1 -parallel 20 -run=TestAccAWSEC2EgressOnlyInternetGateway_success -timeout 180m === RUN TestAccAWSEC2EgressOnlyInternetGateway_success === PAUSE TestAccAWSEC2EgressOnlyInternetGateway_success === CONT TestAccAWSEC2EgressOnlyInternetGateway_success --- PASS: TestAccAWSEC2EgressOnlyInternetGateway_success (56.53s) PASS ok github.com/hashicorp/terraform-provider-awscc/internal/aws/ec2 58.092s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Adds support for resources with a top-level
Idproperty that isn't theprimaryIdentifier. Previously such resources were suppressed as theIdproperty is mapped to the Terraformidattribute which is used in Cloud Control API operations to uniquely identify the resource.If the resource has a top-level
Idproperty then it is now mapped to a top-level Terraform attribute<type>_id(e.g.flow_log_id) and anidattribute is always injected. The value of theidattribute is the resource's primary identifier.This has the pleasant side-effect of fixing a bug affecting resources that have a top-level
Idproperty and that property is one part of a multi-part primary identifier (e.g.awscc_wafv2_regex_pattern_set).Closes #125.
Closes #1471.
Closes #1259.
Closes #1065.
Closes #1000.
Closes #999.
Closes #688.
Closes #753.