Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top-level id attribute that is not a primary identifier #125

Closed
ewbankkit opened this issue Aug 26, 2021 · 2 comments · Fixed by #1501
Closed

Top-level id attribute that is not a primary identifier #125

ewbankkit opened this issue Aug 26, 2021 · 2 comments · Fixed by #1501
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. runtime-handling Relates to runtime handling and conversion of Terraform configuration to CloudFormation. upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency. upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Aug 26, 2021 •
edited by breathingdust
Loading

There are a handful of resource types

  • awscc_groundstation_config
  • awscc_opensearchservice_domain
  • awscc_opsworkscm_server
  • awscc_redshift_cluster
  • awscc_s3outposts_endpoint
  • awscc_synthetics_canary

that declare their own top-level Id property in the CloudFormation schema, but it is not a primary identifier.
This conflicts with the assumptions we make for the synthesized id attribute.

For now, suppress resource generation for these resource types.

Relates:
@ewbankkit ewbankkit added code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. runtime-handling Relates to runtime handling and conversion of Terraform configuration to CloudFormation. labels Aug 26, 2021
@ewbankkit ewbankkit mentioned this issue Aug 26, 2021
Merged
@ewbankkit ewbankkit added the upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency. label Aug 26, 2021
@ewbankkit
Copy link
Contributor Author

We should consider raising this with AWS.

@breathingdust breathingdust mentioned this issue Sep 15, 2021
Open
@ewbankkit ewbankkit mentioned this issue Sep 16, 2021
Merged
@breathingdust breathingdust added the upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework label Nov 17, 2021
@ioannis-klonatos ioannis-klonatos mentioned this issue Oct 7, 2022
Closed
@ewbankkit ewbankkit mentioned this issue Nov 22, 2022
Closed
@kadrach kadrach mentioned this issue Jun 14, 2023
Closed
@kadrach kadrach mentioned this issue Oct 20, 2023
Closed
@breathingdust breathingdust mentioned this issue Mar 20, 2024
Closed
@PeterBurner
Copy link

PeterBurner commented Mar 21, 2024 •
edited
Loading

This issue has been open for some time now. Any news on this?
Can the community do anything to help here? Is there maybe a PFR at AWS we can push?
If AWS won't or cannot fix this due to backwards compatibility maybe its time to think of alternative solutions?

@ewbankkit ewbankkit mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. runtime-handling Relates to runtime handling and conversion of Terraform configuration to CloudFormation. upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency. upstream-plugin-framework Unable to proceed due to missing or broken functionality from terraform-plugin-framework
Projects
None yet
Milestone
No milestone
3 participants
@breathingdust @ewbankkit @PeterBurner