Fix for panic when attempting to read resource identifier after creat…

…ing resource has failed.
hashicorp · Sep 19, 2024 · bff6480 · bff6480
1 parent ef97dde
commit bff6480
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/generic/resource.go b/internal/generic/resource.go
@@ -394,7 +394,11 @@ func (r *genericResource) Create(ctx context.Context, request resource.CreateReq
 
 	err = waiter.Wait(ctx, &cloudcontrol.GetResourceRequestStatusInput{RequestToken: output.ProgressEvent.RequestToken}, r.createTimeout)
 
-	id := aws.ToString(progressEvent.Identifier)
+	// If the resource failed to create, then Identifier may be a nil ptr
+	var id string
+	if progressEvent.Identifier != nil {
+		id = aws.ToString(progressEvent.Identifier)
+	}
 
 	if err != nil {
 		response.Diagnostics.Append(ServiceOperationWaiterErrorDiag("Cloud Control API", "CreateResource", err))