-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/elasticache_serverless_cache: fix modify error using autoflex #40969
Merged
+95
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/elasticache
Issues and PRs that pertain to the elasticache service.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
labels
Jan 16, 2025
ewbankkit
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elasticache/... -v -count 1 -parallel 3 -run=TestAccElastiCacheServerlessCache_ -timeout 360m -vet=off
2025/01/16 14:40:28 Initializing Terraform AWS Provider...
=== RUN TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN TestAccElastiCacheServerlessCache_basicValkey
=== PAUSE TestAccElastiCacheServerlessCache_basicValkey
=== RUN TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
=== PAUSE TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
=== RUN TestAccElastiCacheServerlessCache_fullValkey
=== PAUSE TestAccElastiCacheServerlessCache_fullValkey
=== RUN TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== RUN TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== RUN TestAccElastiCacheServerlessCache_update_RedisToValkey
=== PAUSE TestAccElastiCacheServerlessCache_update_RedisToValkey
=== RUN TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT TestAccElastiCacheServerlessCache_basicRedis
=== CONT TestAccElastiCacheServerlessCache_update
=== CONT TestAccElastiCacheServerlessCache_fullRedis
--- PASS: TestAccElastiCacheServerlessCache_update (394.73s)
=== CONT TestAccElastiCacheServerlessCache_disappears
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (511.82s)
=== CONT TestAccElastiCacheServerlessCache_tags
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (533.41s)
=== CONT TestAccElastiCacheServerlessCache_fullValkey
--- PASS: TestAccElastiCacheServerlessCache_disappears (373.02s)
=== CONT TestAccElastiCacheServerlessCache_update_RedisToValkey
=== CONT TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
--- PASS: TestAccElastiCacheServerlessCache_tags (367.54s)
--- PASS: TestAccElastiCacheServerlessCache_fullValkey (385.74s)
=== CONT TestAccElastiCacheServerlessCache_updatesc
--- PASS: TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup (535.02s)
=== CONT TestAccElastiCacheServerlessCache_full
--- PASS: TestAccElastiCacheServerlessCache_update_RedisToValkey (693.59s)
=== CONT TestAccElastiCacheServerlessCache_basicValkey
--- PASS: TestAccElastiCacheServerlessCache_updatesc (617.17s)
--- PASS: TestAccElastiCacheServerlessCache_full (386.93s)
--- PASS: TestAccElastiCacheServerlessCache_basicValkey (407.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 1874.555s
ewbankkit
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/elasticache
Issues and PRs that pertain to the elasticache service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When modifying and
aws_elasticache_serverless_cache
the resource can sometimes throw the following error due all parameters being passed to the update:Relations
Closes #37499
Closes #40461
References
Output from Acceptance Testing