Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on_failure parameter with retry configuration handling for codepipeline #40936

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shblue21
Copy link
Contributor

@shblue21 shblue21 commented Jan 15, 2025

Description

Modify the CodePipeline resource to add a new on_failure parameter. This parameter is defined as a map containing a required retry field and an optional retry_configuration block, which itself includes a retry_mode field. Internally, this change introduces two new expand functions (expandFailureConditions, expandRetryConfiguration) and their corresponding flatten functions (flattenFailureConditions, flattenRetryConfiguration) to handle reading and writing these values.

Relations

Closes #39966

References

Output from Acceptance Testing

kimjihun@gimjihun-ui-MacBookPro terraform-provider-aws % make testacc TESTS=TestAccCodePipeline_onFailure PKG=codepipeline
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codepipeline/... -v -count 1 -parallel 20 -run='TestAccCodePipeline_onFailure'  -timeout 360m
2025/01/12 20:37:23 Initializing Terraform AWS Provider...
=== RUN   TestAccCodePipeline_onFailure
=== PAUSE TestAccCodePipeline_onFailure
=== CONT  TestAccCodePipeline_onFailure
--- PASS: TestAccCodePipeline_onFailure (63.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       68.599s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codepipeline Issues and PRs that pertain to the codepipeline service. needs-triage Waiting for first response or review from a maintainer. labels Jan 15, 2025
@shblue21 shblue21 changed the title feat: add retry mode to codepipepline action feat: add on_failure parameter with retry configuration handling for codepipeline Jan 15, 2025
@shblue21 shblue21 force-pushed the f-codepipeline-support-autoretry branch from 1c460b1 to 46645c3 Compare January 15, 2025 10:25
@shblue21 shblue21 marked this pull request as ready for review January 15, 2025 11:06
@shblue21 shblue21 requested a review from a team as a code owner January 15, 2025 11:06
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_codepipeline: support auto-retry on failure
2 participants