Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Reduce uses of resource.TestCheckResourceAttrSet with ARN attributes: f to i services #40930

Merged
merged 6 commits into from
Jan 15, 2025
Merged

testing: Reduce uses of resource.TestCheckResourceAttrSet with ARN attributes: f to i services #40930

merged 6 commits into from
Jan 15, 2025
+138 −76

Conversation

gdavison
Copy link
Contributor

Description

Reduce uses of resource.TestCheckResourceAttrSet on ARN attributes in favour of explicit checks

Addresses f through i services

Adds arn attribute to globalaccelerator resources

@gdavison gdavison requested a review from a team as a code owner January 15, 2025 00:42
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/guardduty Issues and PRs that pertain to the guardduty service. service/firehose Issues and PRs that pertain to the firehose service. service/shield Issues and PRs that pertain to the shield service. service/iot Issues and PRs that pertain to the iot service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 15, 2025
ewbankkit
ewbankkit approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 15, 2025
@gdavison gdavison merged commit d575d99 into main Jan 15, 2025
52 checks passed
@gdavison gdavison deleted the td-testcheckresourceattrset-arn branch January 15, 2025 17:51
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 15, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 15, 2025
Update CHANGELOG.md for #40930
e4f8794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/firehose Issues and PRs that pertain to the firehose service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/guardduty Issues and PRs that pertain to the guardduty service. service/iam Issues and PRs that pertain to the iam service. service/iot Issues and PRs that pertain to the iot service. service/shield Issues and PRs that pertain to the shield service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.84.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit