Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix S3 on Outposts read error for aws_datasync_location_s3 #40929

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix: Fix S3 on Outposts read error for aws_datasync_location_s3 #40929

merged 4 commits into from
Jan 15, 2025
+241 −11

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jan 14, 2025 •
edited
Loading

Description

This PR is to fix a global ID parse error when reading an S3 location that is on AWS Outposts.

Note that due to the difficulty in setting up Outposts in a unit test scenario, I am unable to unit test the resource fully.

Relations

Closes #40693

References

Referred to CreateLocationS3 for specs and wordings.

Output from Acceptance Testing

$ make testacc TESTS=TestAccDataSyncLocationS3_ PKG=datasync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncLocationS3_'  -timeout 360m
2025/01/14 17:44:16 Initializing Terraform AWS Provider...
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN   TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_basic
=== CONT  TestAccDataSyncLocationS3_disappears
=== CONT  TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (24.73s)
--- PASS: TestAccDataSyncLocationS3_disappears (29.04s)
--- PASS: TestAccDataSyncLocationS3_basic (32.24s)
--- PASS: TestAccDataSyncLocationS3_tags (56.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   56.438s

$
$ make testacc TESTS="TestGlobalIDFromLocationURI|TestSubdirectoryFromLocationURI" PKG=datasync
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestGlobalIDFromLocationURI|TestSubdirectoryFromLocationURI'  -timeout 360m
2025/01/14 17:43:20 Initializing Terraform AWS Provider...
=== RUN   TestGlobalIDFromLocationURI
=== PAUSE TestGlobalIDFromLocationURI
=== RUN   TestSubdirectoryFromLocationURI
=== PAUSE TestSubdirectoryFromLocationURI
=== CONT  TestGlobalIDFromLocationURI
=== CONT  TestSubdirectoryFromLocationURI
=== RUN   TestGlobalIDFromLocationURI/empty_URI
=== PAUSE TestGlobalIDFromLocationURI/empty_URI
=== RUN   TestSubdirectoryFromLocationURI/empty_URI
=== PAUSE TestSubdirectoryFromLocationURI/empty_URI
=== RUN   TestGlobalIDFromLocationURI/invalid_URI_scheme
=== RUN   TestSubdirectoryFromLocationURI/invalid_URI_scheme
=== PAUSE TestSubdirectoryFromLocationURI/invalid_URI_scheme
=== PAUSE TestGlobalIDFromLocationURI/invalid_URI_scheme
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== PAUSE TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== RUN   TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== PAUSE TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== RUN   TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== PAUSE TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== PAUSE TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/S3_bucket_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/S3_bucket_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/S3_bucket_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/S3_bucket_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/S3_bucket_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/S3_bucket_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/EFS_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/EFS_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/EFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/EFS_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/EFS_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/EFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/EFS_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/EFS_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/EFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/NFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/NFS_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/NFS_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/NFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/NFS_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/NFS_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/NFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/SMB_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/SMB_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/NFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/NFS_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/SMB_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/SMB_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/SMB_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/HDFS_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/SMB_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/HDFS_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/SMB_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/HDFS_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/HDFS_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/SMB_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/SMB_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/HDFS_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/HDFS_URI_top_level
=== PAUSE TestSubdirectoryFromLocationURI/HDFS_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/HDFS_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/HDFS_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/HDFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/HDFS_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/HDFS_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/FSx_Windows_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/FSx_Windows_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/FSx_Windows_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/FSx_Windows_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/FSx_Windows_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/FSx_Zfs_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/FSx_Windows_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Zfs_URI_top_level
=== RUN   TestGlobalIDFromLocationURI/FSx_Zfs_URI_top_level
=== PAUSE TestGlobalIDFromLocationURI/FSx_Zfs_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Zfs_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Zfs_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/FSx_Zfs_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/FSx_Zfs_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Zfs_URI_two_levels
=== RUN   TestGlobalIDFromLocationURI/FSx_Zfs_URI_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/FSx_Zfs_URI_two_levels
=== PAUSE TestGlobalIDFromLocationURI/FSx_Zfs_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/Object_storage_two_levels
=== PAUSE TestSubdirectoryFromLocationURI/Object_storage_two_levels
=== RUN   TestGlobalIDFromLocationURI/Object_storage_two_levels
=== PAUSE TestGlobalIDFromLocationURI/Object_storage_two_levels
=== RUN   TestSubdirectoryFromLocationURI/Azure_blob_URI_one_level
=== PAUSE TestSubdirectoryFromLocationURI/Azure_blob_URI_one_level
=== RUN   TestGlobalIDFromLocationURI/Azure_blob_URI_one_level
=== PAUSE TestGlobalIDFromLocationURI/Azure_blob_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/empty_URI
=== CONT  TestGlobalIDFromLocationURI/FSx_Zfs_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/NFS_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/FSx_Zfs_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/FSx_Zfs_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/Azure_blob_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/Object_storage_two_levels
=== CONT  TestGlobalIDFromLocationURI/FSx_Zfs_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/FSx_Windows_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/FSx_Windows_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/FSx_Windows_URI_top_level
=== CONT  TestGlobalIDFromLocationURI/NFS_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/Azure_blob_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/NFS_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/EFS_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/HDFS_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/S3_bucket_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/EFS_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/EFS_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== CONT  TestSubdirectoryFromLocationURI/EFS_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/HDFS_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/NFS_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/S3_bucket_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/NFS_URI_top_level
=== CONT  TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== CONT  TestGlobalIDFromLocationURI/HDFS_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== CONT  TestSubdirectoryFromLocationURI/HDFS_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/HDFS_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/invalid_URI_scheme
=== CONT  TestSubdirectoryFromLocationURI/SMB_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/SMB_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/SMB_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/HDFS_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/EFS_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/Object_storage_two_levels
=== CONT  TestGlobalIDFromLocationURI/SMB_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/SMB_URI_one_level
=== CONT  TestSubdirectoryFromLocationURI/invalid_URI_scheme
=== CONT  TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level
=== CONT  TestGlobalIDFromLocationURI/SMB_URI_top_level
=== CONT  TestGlobalIDFromLocationURI/NFS_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/FSx_Zfs_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level
=== CONT  TestSubdirectoryFromLocationURI/FSx_Zfs_URI_top_level
=== CONT  TestGlobalIDFromLocationURI/S3_bucket_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== CONT  TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels
=== CONT  TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== CONT  TestSubdirectoryFromLocationURI/EFS_URI_one_level
=== CONT  TestGlobalIDFromLocationURI/empty_URI
--- PASS: TestSubdirectoryFromLocationURI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/empty_URI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/Azure_blob_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/HDFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/Object_storage_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/invalid_URI_scheme (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Zfs_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_one_level (0.00s)
--- PASS: TestGlobalIDFromLocationURI (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Zfs_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/Azure_blob_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Zfs_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/Object_storage_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Zfs_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Windows_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Windows_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/FSx_Windows_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/NFS_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/NFS_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/EFS_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/HDFS_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_bucket_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/EFS_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/EFS_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/HDFS_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_bucket_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(2) (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/HDFS_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/invalid_URI_scheme (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/SMB_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/SMB_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/SMB_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/NFS_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_top_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_bucket_URI_one_level (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_Outposts_ARN_URI_two_levels (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/S3_bucket_URI_no_bucket_name_(1) (0.00s)
    --- PASS: TestGlobalIDFromLocationURI/empty_URI (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   0.224s

$

@acwwat acwwat requested a review from a team as a code owner January 14, 2025 22:45
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 14, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 14, 2025
@acwwat acwwat force-pushed the f-aws_datasync_location_s3-fix_s3_on_outposts_read_err branch 3 times, most recently from 4c48873 to 9c1778a Compare January 14, 2025 23:02
@acwwat acwwat force-pushed the f-aws_datasync_location_s3-fix_s3_on_outposts_read_err branch from 9c1778a to b5dbce6 Compare January 14, 2025 23:44
@ewbankkit ewbankkit self-assigned this Jan 15, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 15, 2025
ewbankkit
ewbankkit approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncLocationS3_' PKG=datasync ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/datasync/... -v -count 1 -parallel 3  -run=TestAccDataSyncLocationS3_ -timeout 360m -vet=off
2025/01/15 14:32:38 Initializing Terraform AWS Provider...
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN   TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT  TestAccDataSyncLocationS3_basic
=== CONT  TestAccDataSyncLocationS3_disappears
=== CONT  TestAccDataSyncLocationS3_tags
--- PASS: TestAccDataSyncLocationS3_disappears (25.30s)
=== CONT  TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_basic (27.13s)
--- PASS: TestAccDataSyncLocationS3_storageClass (16.22s)
--- PASS: TestAccDataSyncLocationS3_tags (48.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	53.984s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d98c23d into hashicorp:main Jan 15, 2025
44 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.84.0
4 participants
@acwwat @ewbankkit @jar-b @justinretzolk