-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eks: add ephemeral aws_eks_cluster_auth
resource
#40660
Merged
johnsonaj
merged 13 commits into
hashicorp:main
from
bschaatsbergen:e/aws-eks-cluster-auth
Jan 16, 2025
Merged
eks: add ephemeral aws_eks_cluster_auth
resource
#40660
johnsonaj
merged 13 commits into
hashicorp:main
from
bschaatsbergen:e/aws-eks-cluster-auth
Jan 16, 2025
+200
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/eks
Issues and PRs that pertain to the eks service.
needs-triage
Waiting for first response or review from a maintainer.
external-maintainer
Contribution from a trusted external contributor.
labels
Dec 20, 2024
github-actions
bot
added
the
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
label
Dec 20, 2024
Add return statements in error paths, and reference the EKS cluster name using ValueString to ensure it produces a literal value. This avoids generating the underlying framework’s string literal, which includes quotes and leads to incorrect token generation.
johnsonaj
added
new-ephemeral-resource
Introduces a new ephemeral resource.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Dec 23, 2024
bschaatsbergen
removed
the
external-maintainer
Contribution from a trusted external contributor.
label
Dec 23, 2024
github-actions
bot
added
the
external-maintainer
Contribution from a trusted external contributor.
label
Dec 23, 2024
github-actions
bot
added
the
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
label
Jan 15, 2025
johnsonaj
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccEKSClusterAuthEphemeral_basic' PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/eks/... -v -count 1 -parallel 20 -run=TestAccEKSClusterAuthEphemeral_basic -timeout 360m -vet=off
2025/01/15 14:48:56 Initializing Terraform AWS Provider...
=== RUN TestAccEKSClusterAuthEphemeral_basic
=== PAUSE TestAccEKSClusterAuthEphemeral_basic
=== CONT TestAccEKSClusterAuthEphemeral_basic
--- PASS: TestAccEKSClusterAuthEphemeral_basic (10.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 16.539s
YakDriver
approved these changes
Jan 16, 2025
@bschaatsbergen thank you for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
external-maintainer
Contribution from a trusted external contributor.
generators
Relates to code generators.
new-ephemeral-resource
Introduces a new ephemeral resource.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/eks
Issues and PRs that pertain to the eks service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40343
Since it’s common to configure the Kubernetes provider by injecting a temporary IAM-compatible token for authenticating to the EKS control-plane (currently done using
data.aws_eks_cluster_auth.example.token
).Terraform (1.10) supports referencing ephemeral resource attributes directly in providers. Having an ephemeral variant available of
aws_eks_cluster_auth
would greatly improve the security posture of Terraform users working with Amazon EKS and the Kubernetes or Helm provider as the temporary obtained IAM token is no longer persisted to the state.Test output: