Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Field for CloudTrail Events #40629

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

hi-artem
Copy link
Contributor

@hi-artem hi-artem commented Dec 18, 2024

Description

Add a field allowed by AWS Cloudtrail API and described in this documentation https://docs.aws.amazon.com/awscloudtrail/latest/APIReference/API_AdvancedEventSelector.html

Relations

Fixes #36280 (comment)

Example

resource "aws_cloudtrail" "example" {
  ...
  advanced_event_selector {
    name = "Capture DynamoDB data events filtered by human roles"

    field_selector {
      field  = "eventCategory"
      equals = ["Data"]
    }

    field_selector {
      field = "userIdentity.arn"

      ends_with = [
        "HumanRole"
      ]
    }

    field_selector {
      field  = "resources.type"
      equals = ["AWS::DynamoDB::Table"]
    }
  }
}

Error:

Error: expected advanced_event_selector.3.field_selector.0.field to be one of ["eventCategory" "eventName" "eventSource" "readOnly" "resources.ARN" "resources.type"], got userIdentity.arn

  on ../../modules/tf12/aws-cloudtrail/main.tf line 268, in resource "aws_cloudtrail" "main":
 268:   advanced_event_selector {

References

Screenshot 2024-12-18 at 2 55 04 PM

See https://docs.aws.amazon.com/awscloudtrail/latest/APIReference/API_AdvancedEventSelector.html

Output from Acceptance Testing

n/a

@hi-artem hi-artem requested a review from a team as a code owner December 18, 2024 22:55
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @hi-artem 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. bug Addresses a defect in current functionality. labels Jan 9, 2025
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

> make testacc PKG=cloudtrail TESTS=TestAccCloudTrailEventDataStore_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20 -run='TestAccCloudTrailEventDataStore_'  -timeout 360m -vet=off
2025/01/15 00:27:27 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN   TestAccCloudTrailEventDataStore_billingMode
=== PAUSE TestAccCloudTrailEventDataStore_billingMode
=== RUN   TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN   TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN   TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN   TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN   TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT  TestAccCloudTrailEventDataStore_basic
=== CONT  TestAccCloudTrailEventDataStore_tags
=== CONT  TestAccCloudTrailEventDataStore_kmsKeyId
=== CONT  TestAccCloudTrailEventDataStore_billingMode
=== CONT  TestAccCloudTrailEventDataStore_disappears
=== CONT  TestAccCloudTrailEventDataStore_options
=== CONT  TestAccCloudTrailEventDataStore_advancedEventSelector
=== NAME  TestAccCloudTrailEventDataStore_options
    event_data_store_test.go:206: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudTrailEventDataStore_options (0.77s)
--- PASS: TestAccCloudTrailEventDataStore_disappears (16.00s)
--- PASS: TestAccCloudTrailEventDataStore_basic (18.22s)
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (18.68s)
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (23.48s)
--- PASS: TestAccCloudTrailEventDataStore_billingMode (26.91s)
--- PASS: TestAccCloudTrailEventDataStore_tags (38.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 45.464s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nam054 nam054 merged commit 4b2114e into hashicorp:main Jan 15, 2025
34 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: CloudTrail - Allow undocumented field in advanced event selector
4 participants