-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Field for CloudTrail Events #40629
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @hi-artem 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
> make testacc PKG=cloudtrail TESTS=TestAccCloudTrailEventDataStore_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20 -run='TestAccCloudTrailEventDataStore_' -timeout 360m -vet=off
2025/01/15 00:27:27 Initializing Terraform AWS Provider...
=== RUN TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN TestAccCloudTrailEventDataStore_billingMode
=== PAUSE TestAccCloudTrailEventDataStore_billingMode
=== RUN TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT TestAccCloudTrailEventDataStore_basic
=== CONT TestAccCloudTrailEventDataStore_tags
=== CONT TestAccCloudTrailEventDataStore_kmsKeyId
=== CONT TestAccCloudTrailEventDataStore_billingMode
=== CONT TestAccCloudTrailEventDataStore_disappears
=== CONT TestAccCloudTrailEventDataStore_options
=== CONT TestAccCloudTrailEventDataStore_advancedEventSelector
=== NAME TestAccCloudTrailEventDataStore_options
event_data_store_test.go:206: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudTrailEventDataStore_options (0.77s)
--- PASS: TestAccCloudTrailEventDataStore_disappears (16.00s)
--- PASS: TestAccCloudTrailEventDataStore_basic (18.22s)
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (18.68s)
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (23.48s)
--- PASS: TestAccCloudTrailEventDataStore_billingMode (26.91s)
--- PASS: TestAccCloudTrailEventDataStore_tags (38.75s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 45.464s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
Add a field allowed by AWS Cloudtrail API and described in this documentation https://docs.aws.amazon.com/awscloudtrail/latest/APIReference/API_AdvancedEventSelector.html
Relations
Fixes #36280 (comment)
Example
Error:
References
See https://docs.aws.amazon.com/awscloudtrail/latest/APIReference/API_AdvancedEventSelector.html
Output from Acceptance Testing
n/a