Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AWS partition metadata from names with endpoints #39874

Merged
merged 136 commits into from
Oct 28, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 24, 2024

Description

Replaces AWS partition and Region metadata from this repository's names package with the equivalent endpoints from aws-sdk-go-base.

Relations

Relates #39873.
Relates hashicorp/aws-sdk-go-base#1176.

Output from Acceptance Testing

% make testacc TESTARGS='-run=^TestAcc.*_basic$$' PKG=apigateway ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/apigateway/... -v -count 1 -parallel 4  -run=^TestAcc.*_basic$ -timeout 360m
2024/10/28 08:40:40 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayAPIKeyDataSource_basic
=== PAUSE TestAccAPIGatewayAPIKeyDataSource_basic
=== RUN   TestAccAPIGatewayAPIKey_basic
=== PAUSE TestAccAPIGatewayAPIKey_basic
=== RUN   TestAccAPIGatewayAuthorizerDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizerDataSource_basic
=== RUN   TestAccAPIGatewayAuthorizer_basic
=== PAUSE TestAccAPIGatewayAuthorizer_basic
=== RUN   TestAccAPIGatewayAuthorizersDataSource_basic
=== PAUSE TestAccAPIGatewayAuthorizersDataSource_basic
=== RUN   TestAccAPIGatewayBasePathMapping_basic
=== PAUSE TestAccAPIGatewayBasePathMapping_basic
=== RUN   TestAccAPIGatewayClientCertificate_basic
=== PAUSE TestAccAPIGatewayClientCertificate_basic
=== RUN   TestAccAPIGatewayDeployment_basic
=== PAUSE TestAccAPIGatewayDeployment_basic
=== RUN   TestAccAPIGatewayDocumentationPart_basic
=== PAUSE TestAccAPIGatewayDocumentationPart_basic
=== RUN   TestAccAPIGatewayDocumentationVersion_basic
=== PAUSE TestAccAPIGatewayDocumentationVersion_basic
=== RUN   TestAccAPIGatewayDomainNameDataSource_basic
=== PAUSE TestAccAPIGatewayDomainNameDataSource_basic
=== RUN   TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic
    domain_name_test.go:259: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic (0.00s)
=== RUN   TestAccAPIGatewayExportDataSource_basic
=== PAUSE TestAccAPIGatewayExportDataSource_basic
=== RUN   TestAccAPIGatewayGatewayResponse_basic
=== PAUSE TestAccAPIGatewayGatewayResponse_basic
=== RUN   TestAccAPIGatewayIntegrationResponse_basic
=== PAUSE TestAccAPIGatewayIntegrationResponse_basic
=== RUN   TestAccAPIGatewayIntegration_basic
=== PAUSE TestAccAPIGatewayIntegration_basic
=== RUN   TestAccAPIGatewayMethodResponse_basic
=== PAUSE TestAccAPIGatewayMethodResponse_basic
=== RUN   TestAccAPIGatewayMethod_basic
=== PAUSE TestAccAPIGatewayMethod_basic
=== RUN   TestAccAPIGatewayModel_basic
=== PAUSE TestAccAPIGatewayModel_basic
=== RUN   TestAccAPIGatewayRequestValidator_basic
=== PAUSE TestAccAPIGatewayRequestValidator_basic
=== RUN   TestAccAPIGatewayResourceDataSource_basic
=== PAUSE TestAccAPIGatewayResourceDataSource_basic
=== RUN   TestAccAPIGatewayResource_basic
=== PAUSE TestAccAPIGatewayResource_basic
=== RUN   TestAccAPIGatewayRestAPIDataSource_basic
=== PAUSE TestAccAPIGatewayRestAPIDataSource_basic
=== RUN   TestAccAPIGatewayRestAPIPolicy_basic
=== PAUSE TestAccAPIGatewayRestAPIPolicy_basic
=== RUN   TestAccAPIGatewayRestAPI_basic
=== PAUSE TestAccAPIGatewayRestAPI_basic
=== RUN   TestAccAPIGatewayRestAPI_Policy_basic
=== PAUSE TestAccAPIGatewayRestAPI_Policy_basic
=== RUN   TestAccAPIGatewaySDKDataSource_basic
=== PAUSE TestAccAPIGatewaySDKDataSource_basic
=== RUN   TestAccAPIGatewayUsagePlanKey_basic
=== PAUSE TestAccAPIGatewayUsagePlanKey_basic
=== RUN   TestAccAPIGatewayUsagePlan_basic
=== PAUSE TestAccAPIGatewayUsagePlan_basic
=== RUN   TestAccAPIGatewayVPCLinkDataSource_basic
=== PAUSE TestAccAPIGatewayVPCLinkDataSource_basic
=== RUN   TestAccAPIGatewayVPCLink_basic
=== PAUSE TestAccAPIGatewayVPCLink_basic
=== CONT  TestAccAPIGatewayAPIKeyDataSource_basic
=== CONT  TestAccAPIGatewayMethodResponse_basic
=== CONT  TestAccAPIGatewayRestAPI_basic
=== CONT  TestAccAPIGatewayUsagePlan_basic
--- PASS: TestAccAPIGatewayAPIKeyDataSource_basic (10.58s)
=== CONT  TestAccAPIGatewayVPCLink_basic
--- PASS: TestAccAPIGatewayRestAPI_basic (13.59s)
=== CONT  TestAccAPIGatewayVPCLinkDataSource_basic
--- PASS: TestAccAPIGatewayUsagePlan_basic (45.16s)
=== CONT  TestAccAPIGatewaySDKDataSource_basic
--- PASS: TestAccAPIGatewayMethodResponse_basic (76.02s)
=== CONT  TestAccAPIGatewayUsagePlanKey_basic
--- PASS: TestAccAPIGatewayUsagePlanKey_basic (19.34s)
=== CONT  TestAccAPIGatewayResourceDataSource_basic
--- PASS: TestAccAPIGatewayResourceDataSource_basic (22.68s)
=== CONT  TestAccAPIGatewayRestAPIPolicy_basic
--- PASS: TestAccAPIGatewayRestAPIPolicy_basic (20.87s)
=== CONT  TestAccAPIGatewayRestAPIDataSource_basic
--- PASS: TestAccAPIGatewayRestAPIDataSource_basic (113.11s)
=== CONT  TestAccAPIGatewayResource_basic
--- PASS: TestAccAPIGatewayResource_basic (34.26s)
=== CONT  TestAccAPIGatewayRestAPI_Policy_basic
--- PASS: TestAccAPIGatewayRestAPI_Policy_basic (32.07s)
=== CONT  TestAccAPIGatewayModel_basic
--- PASS: TestAccAPIGatewayModel_basic (18.30s)
=== CONT  TestAccAPIGatewayRequestValidator_basic
--- PASS: TestAccAPIGatewayRequestValidator_basic (30.78s)
=== CONT  TestAccAPIGatewayDocumentationPart_basic
--- PASS: TestAccAPIGatewayDocumentationPart_basic (67.61s)
=== CONT  TestAccAPIGatewayIntegration_basic
--- PASS: TestAccAPIGatewayIntegration_basic (46.04s)
=== CONT  TestAccAPIGatewayIntegrationResponse_basic
--- PASS: TestAccAPIGatewayIntegrationResponse_basic (22.33s)
=== CONT  TestAccAPIGatewayGatewayResponse_basic
--- PASS: TestAccAPIGatewayGatewayResponse_basic (20.74s)
=== CONT  TestAccAPIGatewayExportDataSource_basic
--- PASS: TestAccAPIGatewayExportDataSource_basic (112.95s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_basic
--- PASS: TestAccAPIGatewayVPCLinkDataSource_basic (639.83s)
=== CONT  TestAccAPIGatewayDocumentationVersion_basic
--- PASS: TestAccAPIGatewayDomainNameDataSource_basic (19.07s)
=== CONT  TestAccAPIGatewayMethod_basic
--- PASS: TestAccAPIGatewayDocumentationVersion_basic (14.93s)
=== CONT  TestAccAPIGatewayAuthorizersDataSource_basic
--- PASS: TestAccAPIGatewayAuthorizersDataSource_basic (33.78s)
=== CONT  TestAccAPIGatewayDeployment_basic
--- PASS: TestAccAPIGatewayDeployment_basic (16.75s)
=== CONT  TestAccAPIGatewayClientCertificate_basic
--- PASS: TestAccAPIGatewayMethod_basic (73.27s)
=== CONT  TestAccAPIGatewayBasePathMapping_basic
--- PASS: TestAccAPIGatewayClientCertificate_basic (20.14s)
=== CONT  TestAccAPIGatewayAuthorizerDataSource_basic
--- PASS: TestAccAPIGatewayVPCLink_basic (752.57s)
=== CONT  TestAccAPIGatewayAuthorizer_basic
--- PASS: TestAccAPIGatewayBasePathMapping_basic (65.87s)
=== CONT  TestAccAPIGatewayAPIKey_basic
--- PASS: TestAccAPIGatewayAuthorizer_basic (36.63s)
--- PASS: TestAccAPIGatewayAPIKey_basic (19.50s)
--- PASS: TestAccAPIGatewayAuthorizerDataSource_basic (101.15s)
--- PASS: TestAccAPIGatewaySDKDataSource_basic (947.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	997.661s
% make testacc TESTARGS='-run=^TestAcc.*_basic$$' PKG=apigatewayv2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 4  -run=^TestAcc.*_basic$ -timeout 360m
2024/10/28 09:50:30 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayV2Authorizer_basic
=== PAUSE TestAccAPIGatewayV2Authorizer_basic
=== RUN   TestAccAPIGatewayV2Deployment_basic
=== PAUSE TestAccAPIGatewayV2Deployment_basic
=== RUN   TestAccAPIGatewayV2DomainName_basic
=== PAUSE TestAccAPIGatewayV2DomainName_basic
=== RUN   TestAccAPIGatewayV2DomainName_MutualTLSAuthentication_basic
    domain_name_test.go:168: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayV2DomainName_MutualTLSAuthentication_basic (0.00s)
=== RUN   TestAccAPIGatewayV2ExportDataSource_basic
=== PAUSE TestAccAPIGatewayV2ExportDataSource_basic
=== RUN   TestAccAPIGatewayV2IntegrationResponse_basic
=== PAUSE TestAccAPIGatewayV2IntegrationResponse_basic
=== RUN   TestAccAPIGatewayV2Model_basic
=== PAUSE TestAccAPIGatewayV2Model_basic
=== RUN   TestAccAPIGatewayV2RouteResponse_basic
=== PAUSE TestAccAPIGatewayV2RouteResponse_basic
=== RUN   TestAccAPIGatewayV2Route_basic
=== PAUSE TestAccAPIGatewayV2Route_basic
=== RUN   TestAccAPIGatewayV2VPCLinkDataSource_basic
=== PAUSE TestAccAPIGatewayV2VPCLinkDataSource_basic
=== RUN   TestAccAPIGatewayV2VPCLink_basic
=== PAUSE TestAccAPIGatewayV2VPCLink_basic
=== CONT  TestAccAPIGatewayV2Authorizer_basic
=== CONT  TestAccAPIGatewayV2Model_basic
=== CONT  TestAccAPIGatewayV2VPCLinkDataSource_basic
=== CONT  TestAccAPIGatewayV2VPCLink_basic
--- PASS: TestAccAPIGatewayV2Model_basic (14.66s)
=== CONT  TestAccAPIGatewayV2ExportDataSource_basic
--- PASS: TestAccAPIGatewayV2ExportDataSource_basic (12.63s)
=== CONT  TestAccAPIGatewayV2IntegrationResponse_basic
=== CONT  TestAccAPIGatewayV2DomainName_basic
--- PASS: TestAccAPIGatewayV2IntegrationResponse_basic (14.43s)
--- PASS: TestAccAPIGatewayV2Authorizer_basic (51.52s)
=== CONT  TestAccAPIGatewayV2Deployment_basic
--- PASS: TestAccAPIGatewayV2DomainName_basic (18.54s)
=== CONT  TestAccAPIGatewayV2Route_basic
--- PASS: TestAccAPIGatewayV2Route_basic (13.65s)
=== CONT  TestAccAPIGatewayV2RouteResponse_basic
--- PASS: TestAccAPIGatewayV2Deployment_basic (24.07s)
--- PASS: TestAccAPIGatewayV2RouteResponse_basic (15.36s)
--- PASS: TestAccAPIGatewayV2VPCLinkDataSource_basic (152.83s)
--- PASS: TestAccAPIGatewayV2VPCLink_basic (353.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	358.414s
% make testacc TESTARGS='-run=^TestAcc.*_basic$$' PKG=devicefarm ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/devicefarm/... -v -count 1 -parallel 4  -run=^TestAcc.*_basic$ -timeout 360m
2024/10/28 10:07:48 Initializing Terraform AWS Provider...
=== RUN   TestAccDeviceFarmDevicePool_basic
=== PAUSE TestAccDeviceFarmDevicePool_basic
=== RUN   TestAccDeviceFarmInstanceProfile_basic
=== PAUSE TestAccDeviceFarmInstanceProfile_basic
=== RUN   TestAccDeviceFarmNetworkProfile_basic
=== PAUSE TestAccDeviceFarmNetworkProfile_basic
=== RUN   TestAccDeviceFarmProject_basic
=== PAUSE TestAccDeviceFarmProject_basic
=== RUN   TestAccDeviceFarmTestGridProject_basic
=== PAUSE TestAccDeviceFarmTestGridProject_basic
=== RUN   TestAccDeviceFarmUpload_basic
=== PAUSE TestAccDeviceFarmUpload_basic
=== CONT  TestAccDeviceFarmDevicePool_basic
=== CONT  TestAccDeviceFarmProject_basic
=== CONT  TestAccDeviceFarmNetworkProfile_basic
=== CONT  TestAccDeviceFarmUpload_basic
--- PASS: TestAccDeviceFarmProject_basic (21.22s)
=== CONT  TestAccDeviceFarmInstanceProfile_basic
--- PASS: TestAccDeviceFarmUpload_basic (21.86s)
=== CONT  TestAccDeviceFarmTestGridProject_basic
--- PASS: TestAccDeviceFarmNetworkProfile_basic (22.22s)
--- PASS: TestAccDeviceFarmDevicePool_basic (24.03s)
--- PASS: TestAccDeviceFarmInstanceProfile_basic (20.22s)
--- PASS: TestAccDeviceFarmTestGridProject_basic (19.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	46.778s
% make testacc TESTARGS='-run=^TestAcc.*_basic$$' PKG=meta ACCTEST_PARALLELISM=4    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/meta/... -v -count 1 -parallel 4  -run=^TestAcc.*_basic$ -timeout 360m
2024/10/28 10:12:29 Initializing Terraform AWS Provider...
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaServiceDataSource_basic
=== PAUSE TestAccMetaServiceDataSource_basic
=== RUN   TestAccMetaServicePrincipalDataSource_basic
=== PAUSE TestAccMetaServicePrincipalDataSource_basic
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionDataSource_basic
=== CONT  TestAccMetaIPRangesDataSource_basic
=== CONT  TestAccMetaServiceDataSource_basic
--- PASS: TestAccMetaRegionDataSource_basic (7.55s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaARNDataSource_basic (7.59s)
=== CONT  TestAccMetaServicePrincipalDataSource_basic
--- PASS: TestAccMetaServiceDataSource_basic (7.59s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (8.89s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_basic (5.70s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaPartitionDataSource_basic (7.05s)
--- PASS: TestAccMetaServicePrincipalDataSource_basic (7.03s)
--- PASS: TestAccMetaRegionsDataSource_basic (8.23s)
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (6.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	27.000s
% make testacc TESTARGS='-run=^TestAcc.*_basic$$' PKG=s3 ACCTEST_PARALLELISM=4  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 4  -run=^TestAcc.*_basic$ -timeout 360m
2024/10/28 10:14:21 Initializing Terraform AWS Provider...
=== RUN   TestAccS3BucketAccelerateConfiguration_basic
=== PAUSE TestAccS3BucketAccelerateConfiguration_basic
=== RUN   TestAccS3BucketACL_basic
=== PAUSE TestAccS3BucketACL_basic
=== RUN   TestAccS3BucketAnalyticsConfiguration_basic
=== PAUSE TestAccS3BucketAnalyticsConfiguration_basic
=== RUN   TestAccS3BucketCORSConfiguration_basic
=== PAUSE TestAccS3BucketCORSConfiguration_basic
=== RUN   TestAccS3BucketDataSource_basic
=== PAUSE TestAccS3BucketDataSource_basic
=== RUN   TestAccS3BucketIntelligentTieringConfiguration_basic
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_basic
=== RUN   TestAccS3BucketInventory_basic
=== PAUSE TestAccS3BucketInventory_basic
=== RUN   TestAccS3BucketLifecycleConfiguration_basic
=== PAUSE TestAccS3BucketLifecycleConfiguration_basic
=== RUN   TestAccS3BucketLogging_basic
=== PAUSE TestAccS3BucketLogging_basic
=== RUN   TestAccS3BucketMetric_basic
=== PAUSE TestAccS3BucketMetric_basic
=== RUN   TestAccS3BucketObjectDataSource_basic
=== PAUSE TestAccS3BucketObjectDataSource_basic
=== RUN   TestAccS3BucketObjectLockConfiguration_basic
=== PAUSE TestAccS3BucketObjectLockConfiguration_basic
=== RUN   TestAccS3BucketObject_basic
=== PAUSE TestAccS3BucketObject_basic
=== RUN   TestAccS3BucketObjectsDataSource_basic
=== PAUSE TestAccS3BucketObjectsDataSource_basic
=== RUN   TestAccS3BucketOwnershipControls_basic
=== PAUSE TestAccS3BucketOwnershipControls_basic
=== RUN   TestAccS3BucketPolicyDataSource_basic
=== PAUSE TestAccS3BucketPolicyDataSource_basic
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3BucketReplicationConfiguration_basic
=== PAUSE TestAccS3BucketReplicationConfiguration_basic
=== RUN   TestAccS3BucketServerSideEncryptionConfiguration_basic
=== PAUSE TestAccS3BucketServerSideEncryptionConfiguration_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Duplicate_basic
=== PAUSE TestAccS3Bucket_Duplicate_basic
=== RUN   TestAccS3Bucket_Replication_basic
=== PAUSE TestAccS3Bucket_Replication_basic
=== RUN   TestAccS3BucketVersioning_basic
=== PAUSE TestAccS3BucketVersioning_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3CanonicalUserIDDataSource_basic
=== PAUSE TestAccS3CanonicalUserIDDataSource_basic
=== RUN   TestAccS3DirectoryBucket_basic
=== PAUSE TestAccS3DirectoryBucket_basic
=== RUN   TestAccS3DirectoryBucketsDataSource_basic
=== PAUSE TestAccS3DirectoryBucketsDataSource_basic
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN   TestAccS3ObjectDataSource_basic
=== PAUSE TestAccS3ObjectDataSource_basic
=== RUN   TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== RUN   TestAccS3ObjectsDataSource_basic
=== PAUSE TestAccS3ObjectsDataSource_basic
=== CONT  TestAccS3BucketAccelerateConfiguration_basic
=== CONT  TestAccS3BucketPolicy_basic
=== CONT  TestAccS3BucketLogging_basic
=== CONT  TestAccS3BucketPolicyDataSource_basic
--- PASS: TestAccS3BucketPolicyDataSource_basic (15.22s)
=== CONT  TestAccS3BucketOwnershipControls_basic
--- PASS: TestAccS3BucketPolicy_basic (17.83s)
=== CONT  TestAccS3BucketObjectsDataSource_basic
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (21.93s)
=== CONT  TestAccS3BucketObject_basic
--- PASS: TestAccS3BucketLogging_basic (23.71s)
=== CONT  TestAccS3BucketObjectLockConfiguration_basic
--- PASS: TestAccS3BucketOwnershipControls_basic (17.33s)
=== CONT  TestAccS3BucketObjectDataSource_basic
--- PASS: TestAccS3BucketObject_basic (16.38s)
=== CONT  TestAccS3BucketMetric_basic
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (16.85s)
=== CONT  TestAccS3BucketDataSource_basic
--- PASS: TestAccS3BucketObjectsDataSource_basic (23.12s)
=== CONT  TestAccS3BucketLifecycleConfiguration_basic
--- PASS: TestAccS3BucketObjectDataSource_basic (14.47s)
=== CONT  TestAccS3BucketInventory_basic
--- PASS: TestAccS3BucketDataSource_basic (14.14s)
=== CONT  TestAccS3BucketIntelligentTieringConfiguration_basic
--- PASS: TestAccS3BucketMetric_basic (16.93s)
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
--- PASS: TestAccS3BucketInventory_basic (17.08s)
=== CONT  TestAccS3ObjectsDataSource_basic
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (16.87s)
=== CONT  TestAccS3Object_basic
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (16.66s)
=== CONT  TestAccS3ObjectDataSource_basic
--- PASS: TestAccS3ObjectsDataSource_basic (14.47s)
=== CONT  TestAccS3ObjectCopy_basic
--- PASS: TestAccS3ObjectDataSource_basic (13.93s)
=== CONT  TestAccS3DirectoryBucketsDataSource_basic
--- PASS: TestAccS3Object_basic (16.40s)
=== CONT  TestAccS3DirectoryBucket_basic
--- PASS: TestAccS3ObjectCopy_basic (14.70s)
=== CONT  TestAccS3CanonicalUserIDDataSource_basic
--- PASS: TestAccS3DirectoryBucketsDataSource_basic (13.86s)
=== CONT  TestAccS3Bucket_Basic_basic
--- PASS: TestAccS3CanonicalUserIDDataSource_basic (7.93s)
=== CONT  TestAccS3BucketVersioning_basic
--- PASS: TestAccS3DirectoryBucket_basic (16.36s)
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (69.26s)
=== CONT  TestAccS3Bucket_Duplicate_basic
--- PASS: TestAccS3Bucket_Basic_basic (16.85s)
=== CONT  TestAccS3BucketReplicationConfiguration_basic
--- PASS: TestAccS3Bucket_Duplicate_basic (8.28s)
=== CONT  TestAccS3BucketServerSideEncryptionConfiguration_basic
--- PASS: TestAccS3BucketVersioning_basic (20.72s)
=== CONT  TestAccS3BucketPublicAccessBlock_basic
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (16.50s)
=== CONT  TestAccS3BucketAnalyticsConfiguration_basic
--- PASS: TestAccS3BucketPublicAccessBlock_basic (16.76s)
=== CONT  TestAccS3BucketCORSConfiguration_basic
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (16.34s)
=== CONT  TestAccS3BucketACL_basic
--- PASS: TestAccS3Bucket_Replication_basic (47.37s)
--- PASS: TestAccS3BucketCORSConfiguration_basic (16.54s)
--- PASS: TestAccS3BucketACL_basic (17.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (54.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	176.486s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 24, 2024
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Oct 24, 2024
@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. service/codebuild Issues and PRs that pertain to the codebuild service. service/shield Issues and PRs that pertain to the shield service. service/batch Issues and PRs that pertain to the batch service. service/route53domains Issues and PRs that pertain to the route53domains service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/eks Issues and PRs that pertain to the eks service. service/amplify Issues and PRs that pertain to the amplify service. service/transfer Issues and PRs that pertain to the transfer service. service/fsx Issues and PRs that pertain to the fsx service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. service/route53recoverycontrolconfig Issues and PRs that pertain to the route53recoverycontrolconfig service. service/memorydb Issues and PRs that pertain to the memorydb service. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/logs Issues and PRs that pertain to the logs service. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/chatbot Issues and PRs that pertain to the chatbot service. labels Oct 28, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

One non-blocking comment

names/names.go Show resolved Hide resolved
@ewbankkit ewbankkit merged commit afc50a0 into main Oct 28, 2024
47 checks passed
@ewbankkit ewbankkit deleted the td-names-use-endpoints branch October 28, 2024 18:14
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 28, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/athena Issues and PRs that pertain to the athena service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/budgets Issues and PRs that pertain to the budgets service. service/chatbot Issues and PRs that pertain to the chatbot service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/deploy Issues and PRs that pertain to the deploy service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dms Issues and PRs that pertain to the dms service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/events Issues and PRs that pertain to the events service. service/finspace Issues and PRs that pertain to the finspace service. service/firehose Issues and PRs that pertain to the firehose service. service/fsx Issues and PRs that pertain to the fsx service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/grafana Issues and PRs that pertain to the grafana service. service/guardduty Issues and PRs that pertain to the guardduty service. service/iam Issues and PRs that pertain to the iam service. service/kendra Issues and PRs that pertain to the kendra service. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/lambda Issues and PRs that pertain to the lambda service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/lexv2models Issues and PRs that pertain to the lexv2models service. service/logs Issues and PRs that pertain to the logs service. service/memorydb Issues and PRs that pertain to the memorydb service. service/meta Issues and PRs that pertain to the meta service. service/neptune Issues and PRs that pertain to the neptune service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/opensearch Issues and PRs that pertain to the opensearch service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rbin Issues and PRs that pertain to the rbin service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. service/resourcegroupstaggingapi Issues and PRs that pertain to the resourcegroupstaggingapi service. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53profiles Issues and PRs that pertain to the route53profiles service. service/route53recoverycontrolconfig Issues and PRs that pertain to the route53recoverycontrolconfig service. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/rum Issues and PRs that pertain to the rum service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/securityhub Issues and PRs that pertain to the securityhub service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/ses Issues and PRs that pertain to the ses service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/shield Issues and PRs that pertain to the shield service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/synthetics Issues and PRs that pertain to the synthetics service. service/transcribe Issues and PRs that pertain to the transcribe service. service/transfer Issues and PRs that pertain to the transfer service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/waf Issues and PRs that pertain to the waf service. service/wafregional Issues and PRs that pertain to the wafregional service. service/wavelength Issues and PRs that pertain to the wavelength service. sweeper Pertains to changes to or issues with the sweeper. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants