keyvaluetags: Add support for 'ListTags' with pagination methods

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10831.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

# Pagination tokens in request/reponse but no SDK pagination method
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAthenaWorkGroup_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAthenaWorkGroup_Tags -timeout 120m
=== RUN   TestAccAWSAthenaWorkGroup_Tags
=== PAUSE TestAccAWSAthenaWorkGroup_Tags
=== CONT  TestAccAWSAthenaWorkGroup_Tags
--- PASS: TestAccAWSAthenaWorkGroup_Tags (40.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.665s
# SDK pagination method
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupPlan_withTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_withTags -timeout 120m
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== CONT  TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_withTags (48.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.875s

[ewbankkit]

The list of pagination tokens was generated by an adaption of @kapilt's script:

import boto3
import yaml

def main():
    session = boto3.Session()
    services = session.get_available_services()
    op_missing_paginator = {}
    for s in services:
        c = session.client(s)
        op_to_py = {v: k for k, v in c._PY_TO_OP_NAME.items()}
        for op in c.meta.service_model.operation_names:
            opm = c.meta.service_model.operation_model(op)
            if opm.output_shape is None:
                continue

            input_token = ''
            output_token = ''
            if 'NextToken' in opm.output_shape.members or 'nextToken' in opm.output_shape.members:
                input_token = 'NextToken'
                output_token = 'NextToken'
            elif 'PaginationToken' in opm.output_shape.members:
                input_token = 'PaginationToken'
                output_token = 'PaginationToken'
            elif 'PageToken' in opm.output_shape.members or 'pageToken' in opm.output_shape.members:
                input_token = 'PageToken'
                output_token = 'PageToken'
            elif 'NextPageToken' in opm.output_shape.members or 'nextPageToken' in opm.output_shape.members:
                input_token = 'NextPageToken'
                output_token = 'NextPageToken'
            elif 'Marker' in opm.output_shape.members and 'NextMarker' in opm.output_shape.members or 'marker' in opm.output_shape.members and 'nextMarker' in opm.output_shape.members:
                input_token = 'Marker'
                output_token = 'NextMarker'
            elif 'NextMarker' in opm.output_shape.members or 'nextMarker' in opm.output_shape.members:
                input_token = 'NextMarker'
                output_token = 'NextMarker'
            else:
                continue

            py_name = op_to_py[opm.name]
            if 'tags' in py_name:
                op_missing_paginator.setdefault(s, []).append((py_name, input_token, output_token))

    for s, tokens in op_missing_paginator.items():
        print('case "%s":\nreturn &PaginationTokens{InputToken: "%s", OutputToken: "%s"}' % (s, tokens[0][1], tokens[0][2]))

if __name__ == '__main__':
    main()

[ewbankkit]

See issue comments.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!