fix modules.json and terraform-sources.json overriding each other #1903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1836 added support for parsing
terraform-sources.json
files present in stacks projects. As themodules.json
and theterraform-sources.json
files are mutually exclusive and thus not expected to be present at the same time, that PR re-used the existingInstalledModules
for simplicity. However, it thereby accidentally introduced a race between the two jobs looking for and parsing these files. In the case of hashicorp/vscode-terraform#1915, the job parsingterraform-sources.json
terminated second and overwroteInstalledModules
withnil
as no manifest file was found.This PR adds a simple fix to only overwrite
InstalledModules
if it is notnil
– this is just a short-term bandaid however, given it might lead to stale data. For a long-term fix, we should splitInstalledModules
into two fields instead.Resolves hashicorp/vscode-terraform#1915