Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

feat(install-vault): add multiarch support #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vdice
Copy link

@vdice vdice commented Dec 3, 2021

Description

Adds ability to fetch vault binary according to the host arch to the install-vault script.

Employs the approach used by the install-nomad script in the terraform-aws-nomad repo.

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.

Related Issues

Fixes #249

@vdice vdice requested a review from robmorgan as a code owner December 3, 2021 22:20
@vdice vdice closed this Dec 8, 2021
@vdice vdice deleted the feat/add-multiarch-support-249 branch December 8, 2021 23:46
@vdice vdice restored the feat/add-multiarch-support-249 branch December 9, 2021 00:17
@vdice
Copy link
Author

vdice commented Dec 9, 2021

Oops, didn't mean to delete this branch; re-opening.

@vdice vdice reopened this Dec 9, 2021
Copy link
Contributor

@anouarchattouna anouarchattouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@luong-komorebi
Copy link

What are the blockers on this PR, given that it has not been visited or merged in a while? How can I help?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install vault from latest 0.17 module on ARM
4 participants