Changes to support TProxy #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes to support TProxy * Add validation * Added readme * Add comment * Add validation tests
* Cross namespace communication tests * Fix tests * Fix image * Add admin partitions tproxy test
tauhid621
approved these changes
Jan 18, 2024
tauhid621
approved these changes
Jan 18, 2024
lkysow
reviewed
Jan 18, 2024
| @@ -6,6 +6,18 @@ BREAKING CHANGES | |||
| - Adds a new container named `consul-ecs-health-sync` to the task definition which will be responsible for syncing back ECS container health checks into Consul. This container will wait for a successful exit of `consul-ecs-mesh-init` container before starting. | |||
|
|
|||
| FEATURES | |||
| * Add support for transparent proxy in ECS tasks based on EC2 launch types. Following are the changes made to the `mesh-task` submodule [[GH-264](https://github.com/hashicorp/terraform-aws-consul-ecs/pull/264)] | |||
| - Adds the following variables [[GH-209](https://github.com/hashicorp/terraform-aws-consul-ecs/pull/209)] | |||
| - `enable_transparent_proxy` - Defaults to `true`. Fargate based tasks should explicitly pass `false` to avoid validation errors during terraform planning phase. | |||
There was a problem hiding this comment.
@Ganeshrockz should this be a breaking change? Since it will change all the routing, e.g. everything will be routed to/from the proxy.
There was a problem hiding this comment.
That makes sense. Will move this under the Breaking changes heading in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
Manual & CI
How I expect reviewers to test this PR:
Checklist: