Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic validation to support TGWs #237

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

Ganeshrockz
Copy link
Contributor

Changes proposed in this PR:

  • Add terminating-gateway as an acceptable kind input for the gateway submodule
  • Add validation tests to cover the same.

How I've tested this PR:

CI

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

@Ganeshrockz
Copy link
Contributor Author

The acceptance tests seems to be flaky. Merging this PR to main for now and plan to deal with the failures in a followup PR.

@Ganeshrockz Ganeshrockz merged commit c0c0fa9 into main Dec 8, 2023
7 of 8 checks passed
@Ganeshrockz Ganeshrockz deleted the net-6825/tgw-validation branch December 8, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants