Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference ECS release candidate images for examples and submodules #214

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Reference ECS release candidate images for examples and submodules #214

merged 10 commits into from
Sep 29, 2023

Conversation

Ganeshrockz
Copy link
Contributor

@Ganeshrockz Ganeshrockz commented Sep 28, 2023 •
edited
Loading

Changes proposed in this PR:

  • Bump ECS image variables to refer to the latest release candidate's name
  • Split existing acceptance test matrix into Fargate and EC2 to reduce flakiness

How I've tested this PR:

CI

How I expect reviewers to test this PR:

👁️

Checklist:

  • Tests added
  • CHANGELOG entry added

@Ganeshrockz Ganeshrockz changed the title Bump ECS to use RC image Reference ECS release candidate images for examples and submodules Sep 28, 2023
@Ganeshrockz Ganeshrockz marked this pull request as ready for review September 28, 2023 11:06
@Ganeshrockz Ganeshrockz requested review from a team, marianoasselborn, jeanneryan, johnlanda and cthain and removed request for a team September 28, 2023 11:06
absolutelightning
absolutelightning approved these changes Sep 29, 2023
View reviewed changes
Copy link

@absolutelightning absolutelightning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ganeshrockz Ganeshrockz merged commit 9c7e419 into main Sep 29, 2023
@Ganeshrockz Ganeshrockz deleted the ganeshrockz/bump-ecs-image branch September 29, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absolutelightning absolutelightning absolutelightning approved these changes

@marianoasselborn marianoasselborn Awaiting requested review from marianoasselborn

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

@johnlanda johnlanda Awaiting requested review from johnlanda

@cthain cthain Awaiting requested review from cthain

Assignees
No one assigned
Labels
consul-india
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ganeshrockz @absolutelightning