-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importer-msgraph-metadata: workaround for UnifiedRoleAssignment which has an erroneous read-only field #4430
Merged
manicminer
merged 6 commits into
main
from
importer-msgraph/workaround-unifiedroleassignment
Sep 23, 2024
Merged
importer-msgraph-metadata: workaround for UnifiedRoleAssignment which has an erroneous read-only field #4430
manicminer
merged 6 commits into
main
from
importer-msgraph/workaround-unifiedroleassignment
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has an erroneous read-only field
manicminer
added
bug
Something isn't working
tool/msgraph-importer
Issues related to the Microsoft Graph importer
labels
Sep 21, 2024
manicminer
force-pushed
the
importer-msgraph/workaround-unifiedroleassignment
branch
2 times, most recently
from
September 22, 2024 00:43
3377464
to
0946f5e
Compare
…iate method which also returns 201
…ich also returns 200
manicminer
force-pushed
the
importer-msgraph/workaround-unifiedroleassignment
branch
from
September 22, 2024 00:58
0946f5e
to
dfdc63a
Compare
manicminer
force-pushed
the
importer-msgraph/workaround-unifiedroleassignment
branch
from
September 23, 2024 00:23
4c0ff89
to
d6d17df
Compare
…titlementManagementAccessPackageResourceRoleScope method which actually returns 200
manicminer
force-pushed
the
importer-msgraph/workaround-unifiedroleassignment
branch
from
September 23, 2024 00:35
d6d17df
to
8586e1a
Compare
stephybun
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manicminer LGTM 🥧
manicminer
commented
Sep 23, 2024
...ata/components/workarounds/workaround_service_accesspackageaccesspackageresourcerolescope.go
Outdated
Show resolved
Hide resolved
manicminer
commented
Sep 23, 2024
.../importer-msgraph-metadata/components/workarounds/workaround_service_applicationtemplates.go
Outdated
Show resolved
Hide resolved
manicminer
commented
Sep 23, 2024
tools/importer-msgraph-metadata/components/workarounds/workaround_service_groups.go
Outdated
Show resolved
Hide resolved
manicminer
deleted the
importer-msgraph/workaround-unifiedroleassignment
branch
September 23, 2024 09:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.