[HPR-1420] Remove bundled plugins from Packer core #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
changed the title
nywilken
changed the title
nywilken
force-pushed
the
nywilken/remove-all-bundled-plugins
branch
2 times, most recently
from
5f74a23 to
33f20a7
Compare
lbajolet-hashicorp
approved these changes
Oct 23, 2023
| @@ -1,18 +1,19 @@ | |||
| packer { | |||
There was a problem hiding this comment.
Might be me, but looks like this one is not used, is it?
With the removal of vendored_plugins we are no longer interested in tacking bundled plugins usage. For plugins such as file, null, or anything bultin into Packer we don't track because there is no way to install them outside of Packer, for now.
…ot installed This change updates hcl2_upgrade to not flag known plugin components, those used for generating the required plugins block, when upgrading a legacy JSON template to HCL2. Any unknown plugins will be installed after running packer init on the generated template so we don't error. We may want to suggest running packer init to install any missing plugins. * Move knownPluginPrefixes into the hcl2_upgrade command
nywilken
force-pushed
the
nywilken/remove-all-bundled-plugins
branch
from
33f20a7 to
e57a394
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should go into a feature branch for 1.10.0 where we can iterate on the changes and the addition of the updated plugin loading logic.
Changes
The plugin
github.com/hashicorp/packer-plugin-amazonwas removed as a plugin but the module is still within the go.mod file because it is used as a package within the hcl2_upgrade command.