Custom reporter cannot also have an output file, he finds out two day…

…s late
hashicorp · Nov 28, 2024 · f98bd61 · f98bd61
1 parent bf42fdb
commit f98bd61
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 13 deletions.
diff --git a/ui/test-reporter.js b/ui/test-reporter.js
@@ -1,3 +1,8 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: BUSL-1.1
+ */
+
 /* eslint-env node */
 /* eslint-disable no-console */
 
@@ -6,22 +11,16 @@ const path = require('path');
 
 class JsonReporter {
   constructor(out, socket, config) {
-    // Prevent double initialization
-    if (JsonReporter.instance) {
-      return JsonReporter.instance;
-    }
-    JsonReporter.instance = this;
-
     this.out = out || process.stdout;
     this.results = [];
 
     // Get output file from Testem config
-    this.outputFile = config.fileOptions.report_file || 'test-results.json';
+    this.outputFile =
+      config.fileOptions.custom_report_file || 'test-results/test-results.json';
 
     console.log(`[Reporter] Initializing with output file: ${this.outputFile}`);
 
     try {
-      // Ensure output directory exists
       fs.mkdirSync(path.dirname(this.outputFile), { recursive: true });
 
       // Initialize the results file
@@ -47,6 +46,9 @@ class JsonReporter {
       this.finish();
       process.exit(0);
     });
+
+    this.testCounter = 0;
+    this.startTime = Date.now();
   }
 
   filterLogs(logs) {
@@ -55,6 +57,7 @@ class JsonReporter {
       if (
         log.text &&
         (log.text.includes('Accessor:') ||
+          log.text.includes('log in with a JWT') ||
           log.text === 'TOKENS:' ||
           log.text === '=====================================')
       ) {
@@ -72,7 +75,8 @@ class JsonReporter {
       return;
     }
 
-    console.log(`[Reporter] Processing test: ${data.name}`);
+    this.testCounter++;
+    console.log(`[Reporter] Test #${this.testCounter}: ${data.name}`);
 
     const partitionMatch = data.name.match(/^Exam Partition (\d+) - (.*)/);
 
@@ -103,10 +107,12 @@ class JsonReporter {
       const passed = this.results.filter((r) => r.passed).length;
       const failed = this.results.filter((r) => !r.passed).length;
       const total = this.results.length;
+      const duration = Date.now() - this.startTime;
 
       const output = {
         summary: { total, passed, failed },
         timestamp: new Date().toISOString(),
+        duration,
         tests: this.results,
       };
 
@@ -117,15 +123,15 @@ class JsonReporter {
       console.log(`Total:  ${total}`);
       console.log(`Passed: ${passed}`);
       console.log(`Failed: ${failed}`);
-
+      console.log(`Duration: ${duration}ms`);
       if (failed > 0) {
         console.log('\nFailed Tests:');
         this.results
           .filter((r) => !r.passed)
           .forEach((r) => {
             console.log(`❌ ${r.name}`);
             if (r.error) {
-              console.log(`   ${r.error}`);
+              console.error(r.error);
             }
           });
       }

diff --git a/ui/testem.js b/ui/testem.js
@@ -15,7 +15,11 @@ const config = {
   parallel: -1,
   framework: 'qunit',
   reporter: JsonReporter,
-  report_file: 'test-results/test-results.json',
+  custom_report_file: 'test-results/test-results.json',
+  // report_file: 'test-results/test-results.json',
+  // NOTE: See https://github.com/testem/testem/issues/1073, report_file + custom reporter results in double output.
+  debug: true,
+
   browser_args: {
     // New format in testem/master, but not in a release yet
     // Chrome: {

diff --git a/ui/tests/acceptance/variables-test.js b/ui/tests/acceptance/variables-test.js
@@ -717,7 +717,7 @@ module('Acceptance | variables', function (hooks) {
       assert.ok(confirmFired, 'Confirm fired when leaving with unsaved form');
       assert.equal(
         currentURL(),
-        '/variables/var/Auto-conflicting%20Variable@default/edit',
+        '/variables/var/Auto-conflicting%20Variable@default/editte',
         'Opted to stay, did not leave page'
       );