Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make-gen-delta action #189

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

jimlambrt
Copy link
Collaborator

For now this action only runs on the extras/kms module.

@jimlambrt jimlambrt requested review from jefferai and a team as code owners October 1, 2023 15:52
.github/workflows/make-gen-delta.yml Outdated Show resolved Hide resolved
@jimlambrt jimlambrt force-pushed the jimlambrt-make-gen-delta-action branch 2 times, most recently from e315294 to 40772fd Compare October 2, 2023 13:26
@tmessi
Copy link
Member

tmessi commented Oct 2, 2023

Looks like make-gen-delta is failing due to make tools not installing gofumpt. It looks like there is a typo in the Makefile so make doesn't see the tools target as phony and things the target is up-to-date due to the tools directory existing.

index c198b4b..1861be5 100644
--- a/extras/kms/Makefile
+++ b/extras/kms/Makefile
@@ -1,4 +1,4 @@
-PHONY: tools
+.PHONY: tools
 tools:
 	go generate -tags tools tools/tools.go

@jimlambrt jimlambrt force-pushed the jimlambrt-make-gen-delta-action branch from 40772fd to 2854b81 Compare October 2, 2023 13:33
@jimlambrt jimlambrt requested a review from moduli October 2, 2023 13:34
@jimlambrt jimlambrt merged commit 52f955c into main Oct 2, 2023
29 checks passed
@jimlambrt jimlambrt deleted the jimlambrt-make-gen-delta-action branch October 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants