This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
changelog: add go-changelog templates and tooling #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mikemorris
force-pushed
the
go-changelog
branch
from
February 23, 2022 20:57
2237231
to
70c4544
Compare
mikemorris
force-pushed
the
go-changelog
branch
from
March 30, 2022 18:40
70c4544
to
19db2d8
Compare
2 tasks
…S above DEPRECATIONS
… template, update changelog-entry make task to main branch
…t use types file yet
…angelog entries and one or more digits
The current workflow for changelog generation only happens at release time - for future work we may want to consider implementing hashicorp/go-changelog#5 to allow the |
nathancoleman
suggested changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Excited to see this
nathancoleman
approved these changes
Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
TODO:
make
tasksmake changelog
forchangelog-build
make changelog-entry
for creating a new blank changelog entry file, prompt for entry typecmd: add changelog-entry generation tool go-changelog#19make changelog-check
for validating entries, as described in Add CHANGELOG file contents linting terraform-provider-aws#17135 - would be nice to possibly have this as a git hook if the commit contains a changelog entrychangelog-check
tool upstream out ofchangelog-pr-body-check
, which is a specific implementation oriented around having contributors add changelog notes in the body of a GitHub PR description rather than as a separate file, and has assumptions in the error handling based on the Google Cloud Platform Terraform provider "magic modules" workflowmake changelog-check
to workflowworkflow/no-changelog
label to skip CI checkCheck for spelling errors like .github/workflows/changelog: add .changelog dir to PR path and to misspell run command terraform-provider-aws#17464?aspell
might be a better option than themisspell
Go library that hasn't been maintained in four years, but too much of a lift and possible false negatives to implement right nowHow I've tested this PR:
make changelog
Running
should generate
make changelog-check
should validate the changelog entry for
.changelog/101.txt
successfully with exit code 0should check that the string
foo
is not a valid changelog entry, with exit code 1should check that the string
bar
is not a valid changelog entry type and list the valid configured changelog entry types, with exit code 1make changelog-entry
should detect that the current branch has an open pull request and start an interactive workflow to write a valid changelog entry at
./changelog/101.txt
How I expect reviewers to test this PR:
make
tasks.changelog/changelog.tmpl
is a slight modification of the stock template from go-changelog and is mostly similar to https://github.com/hashicorp/consul/blob/main/.changelog/changelog.tmpl - we should review together and determine what format or tweaks we'd like.changelog/types.txt
, we should discuss whether this list is sufficient for our needsChecklist:
Refs prior implementations in: