Enables configurable API endpoints #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-specific endpoint configured in config file
…r or config file
… endpoint from envvar or config file
gdavison
force-pushed
the
f-configurable-endpoints
branch
from
5fe101f to
92e7c3f
Compare
ewbankkit
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM 🚀.
% go test ./...
go: downloading github.com/aws/aws-sdk-go-v2/service/dynamodb v1.26.6
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.28.5
? github.com/hashicorp/aws-sdk-go-base/v2/configtesting [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/errs [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/slices [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/test [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2 6.248s
ok github.com/hashicorp/aws-sdk-go-base/v2/diag (cached)
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/config 0.642s
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints (cached)
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/expand (cached)
ok github.com/hashicorp/aws-sdk-go-base/v2/logging 0.618s
ok github.com/hashicorp/aws-sdk-go-base/v2/tfawserr 0.478s
ok github.com/hashicorp/aws-sdk-go-base/v2/useragent 0.676s
ok github.com/hashicorp/aws-sdk-go-base/v2/validation (cached)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables configuring API endpoints using environment variables and shared config files using AWS SDK. Requires AWS SDK update.
Closes #602