Skip to content

Commit

Permalink
Merge pull request #1223 from hashicorp/td-comments-on-generated-regions
Browse files Browse the repository at this point in the history
Comments on generated Regions and partitions
  • Loading branch information
ewbankkit authored Dec 2, 2024
2 parents 3cb4211 + bdc3757 commit bcfc476
Show file tree
Hide file tree
Showing 3 changed files with 111 additions and 48 deletions.
3 changes: 2 additions & 1 deletion endpoints/endpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
package endpoints

const (
AwsGlobalRegionID = "aws-global" // AWS Standard global region.
// AWS Standard global region.
AwsGlobalRegionID = "aws-global"
)
150 changes: 105 additions & 45 deletions endpoints/endpoints_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions internal/generate/endpoints/output.go.gtpl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import (
// All known partition IDs.
const (
{{- range .Partitions }}
{{ .ID | IDToTitle}}PartitionID = "{{ .ID }}" // {{ .Name }}
// {{ .Name }}
{{ .ID | IDToTitle}}PartitionID = "{{ .ID }}"
{{- end }}
)

Expand All @@ -21,7 +22,8 @@ const (
{{- range .Partitions }}
// {{ .Name }} partition's Regions.
{{- range .Regions }}
{{ .ID | IDToTitle}}RegionID = "{{ .ID }}" // {{ .Description }}
// {{ .Description }}
{{ .ID | IDToTitle}}RegionID = "{{ .ID }}"
{{- end }}
{{- end }}
)
Expand Down

0 comments on commit bcfc476

Please sign in to comment.