Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FloatingUI package and add is-dragging logic #667

Closed
wants to merge 2 commits into from

Conversation

jeffdaley
Copy link
Contributor

  • Updates the FloatingUI package to get the layoutShift listener/property that allows us to react to changes in the layout.
  • Adds logic to hide a popover when its parent contains the .is-dragging class, as can be the case in the forthcoming drag-and-drop UI.
  • Resolves some Glint errors in the content-test file

@@ -65,7 +66,7 @@ export default class FloatingUIContent extends Component<FloatingUIContentSignat
@action didInsert(e: HTMLElement) {
this._content = e;

const { matchAnchorWidth, anchor, placement } = this.args;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable

@jeffdaley jeffdaley marked this pull request as ready for review April 2, 2024 18:03
@jeffdaley jeffdaley requested a review from a team as a code owner April 2, 2024 18:03
@jeffdaley
Copy link
Contributor Author

Closing this as a separate from #668

@jeffdaley jeffdaley closed this Apr 3, 2024
@jeffdaley jeffdaley deleted the jeffdaley/floating-ui branch April 3, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant