Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve focus styles on Doc::TileMedium #663

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Improve focus styles on Doc::TileMedium #663

merged 2 commits into from
Apr 1, 2024

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Apr 1, 2024 •
edited
Loading

Improves the focus styles of the Doc::TileMedium component.

  • On the dashboard, fixes the left outline being cut off
  • On a project with documents, fixes the last doc's bottom outline being cut off
  • Everywhere: The focus outline now only shows when the primary link is focused (vs. when the overflow menu or forthcoming rearrange control has focus), making it clearer which element is actually focused.

@jeffdaley jeffdaley marked this pull request as ready for review April 1, 2024 19:47
@jeffdaley jeffdaley requested a review from a team as a code owner April 1, 2024 19:47
@jeffdaley jeffdaley merged commit 8aaf601 into main Apr 1, 2024
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/tile-medium-focus branch April 1, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda