Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional ProductAreas fetch call to new/doc route #373

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Oct 18, 2023

Adds a check to the /new/doc route for whether the ProductAreasService's index is loaded. If it's not already loaded, we now await it before rendering the form. This minimizes layout shift when first loading the index.

Also removes unused imports from the ProductAreasService.

@jeffdaley jeffdaley changed the title Add productAreas fetch call to NewDoc screen Add conditional ProductAreas fetch call to new/doc route Oct 18, 2023
@jeffdaley jeffdaley marked this pull request as ready for review October 19, 2023 16:06
@jeffdaley jeffdaley requested a review from a team as a code owner October 19, 2023 16:06
@jeffdaley jeffdaley merged commit 89852b6 into main Oct 20, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/product-areas-service branch October 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants