Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable removing custom fields by providing an empty value #350

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jfreda
Copy link
Collaborator

@jfreda jfreda commented Sep 28, 2023

Currently attempting to remove an RFC or PRD custom field value fails when rewriting the document header, but this is due to a larger issue where you couldn't remove custom fields from a document after adding a value for them. This PR enables removing custom fields from a document by providing an empty value (empty string for a STRING type, and an empty array for a PERSON type).

@jfreda jfreda requested a review from a team as a code owner September 28, 2023 16:46
@jfreda jfreda merged commit 19f7b1f into main Sep 28, 2023
1 check passed
@jfreda jfreda deleted the jfreda/bugfix-error-removing-custom-field-value branch September 28, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants