Add isReadOnly argument to project resources (#522)

* Set `isReadOnly` conditions * Add isReadOnly conditions to project resources * Add tests
hashicorp-forge · Dec 21, 2023 · b6d0702 · b6d0702
1 parent ded85ed
commit b6d0702
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 1 deletion.
diff --git a/web/app/components/project/index.hbs b/web/app/components/project/index.hbs
@@ -156,6 +156,7 @@
           {{#each this.hermesDocuments as |document|}}
             <li class="group relative" data-test-document-list-item>
               <Project::Resource
+                @isReadOnly={{not this.projectIsActive}}
                 @overflowMenuItems={{hash
                   delete=(hash
                     label="Remove"
@@ -189,6 +190,7 @@
           {{#each this.externalLinks as |link i|}}
             <li class="group" data-test-document-list-item>
               <Project::Resource
+                @isReadOnly={{not this.projectIsActive}}
                 @overflowMenuItems={{hash
                   edit=(hash
                     label="Edit"

diff --git a/web/app/components/project/resource.hbs b/web/app/components/project/resource.hbs
@@ -2,5 +2,7 @@
 
   {{yield}}
 
-  <OverflowMenu @items={{@overflowMenuItems}} />
+  {{#unless @isReadOnly}}
+    <OverflowMenu @items={{@overflowMenuItems}} />
+  {{/unless}}
 </div>
diff --git a/web/app/components/project/resource.ts b/web/app/components/project/resource.ts
@@ -5,6 +5,7 @@ interface ProjectResourceComponentSignature {
   Element: HTMLDivElement;
   Args: {
     overflowMenuItems: Record<string, OverflowItem>;
+    isReadOnly?: boolean;
   };
   Blocks: {
     default: [];

diff --git a/web/tests/acceptance/authenticated/projects/project-test.ts b/web/tests/acceptance/authenticated/projects/project-test.ts
@@ -424,6 +424,25 @@ module("Acceptance | authenticated/projects/project", function (hooks) {
     assert.equal(projectDocuments.length, 0);
   });
 
+  test("documents can only be removed if the project is active", async function (this: AuthenticatedProjectsProjectRouteTestContext, assert) {
+    await visit("/projects/1");
+
+    assert.dom(DOCUMENT_LIST_ITEM).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).exists();
+
+    await click(STATUS_TOGGLE);
+    await click(COMPLETED_STATUS_ACTION);
+
+    assert.dom(DOCUMENT_LIST_ITEM).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).doesNotExist();
+
+    await click(STATUS_TOGGLE);
+    await click(ARCHIVED_STATUS_ACTION);
+
+    assert.dom(DOCUMENT_LIST_ITEM).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).doesNotExist();
+  });
+
   test("you can add external links to a project", async function (this: AuthenticatedProjectsProjectRouteTestContext, assert) {
     const project = this.server.schema.projects.first();
 
@@ -537,6 +556,29 @@ module("Acceptance | authenticated/projects/project", function (hooks) {
     assert.equal(projectLinks.length, 0);
   });
 
+  test("external links can only be edited if the project is active", async function (this: AuthenticatedProjectsProjectRouteTestContext, assert) {
+    this.server.schema.projects.first().update({
+      externalLinks: [this.server.create("related-external-link").attrs],
+    });
+
+    await visit("/projects/1");
+
+    assert.dom(EXTERNAL_LINK).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).exists();
+
+    await click(STATUS_TOGGLE);
+    await click(COMPLETED_STATUS_ACTION);
+
+    assert.dom(EXTERNAL_LINK).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).doesNotExist();
+
+    await click(STATUS_TOGGLE);
+    await click(ARCHIVED_STATUS_ACTION);
+
+    assert.dom(EXTERNAL_LINK).exists();
+    assert.dom(OVERFLOW_MENU_BUTTON).doesNotExist();
+  });
+
   test("you can't save an empty project title", async function (this: AuthenticatedProjectsProjectRouteTestContext, assert) {
     await visit("/projects/1");