Add rules; revert changes

hashicorp-forge · Oct 20, 2023 · 89fd8e1 · 89fd8e1
1 parent 5927957
commit 89fd8e1
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 14 deletions.
diff --git a/web/.eslintrc.js b/web/.eslintrc.js
@@ -19,6 +19,26 @@ module.exports = {
     "@typescript-eslint/no-unsafe-argument": "off",
     "@typescript-eslint/no-unsafe-return": "off",
     "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/ban-types": "off",
+    "@typescript-eslint/no-redundant-type-constituents": "off",
+    "@typescript-eslint/require-await": "off",
+    "@typescript-eslint/no-floating-promises": "off",
+    "@typescript-eslint/unbound-method": "off",
+    "@typescript-eslint/no-misused-promises": "off",
+    "@typescript-eslint/restrict-template-expressions": "off",
+    "@typescript-eslint/no-misused-new": "off",
+    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/restrict-plus-operands": "off",
+    "@typescript-eslint/await-thenable": "off",
+    "@typescript-eslint/no-unsafe-enum-comparison": "off",
+    "@typescript-eslint/no-unnecessary-type-assertion": "off",
+    "no-case-declarations": "off",
+    "no-fallthrough": "off",
     "prefer-const": "off",
+    "no-empty-pattern": "off",
+    "no-control-regex": "off",
+    "no-self-assign": "off",
+    "prefer-rest-params": "off",
+    "no-empty": "off",
   },
 };
diff --git a/web/app/components/document/sidebar/related-resources/list-item.ts b/web/app/components/document/sidebar/related-resources/list-item.ts
@@ -71,7 +71,7 @@ export default class DocumentSidebarRelatedResourcesListItemComponent extends Co
    */
   protected get documentObjectID(): string | null {
     if ("googleFileID" in this.args.resource) {
-      return this.args.resource.googleFileID;
+      return (this.args.resource as RelatedHermesDocument).googleFileID;
     } else {
       return null;
     }

diff --git a/web/tests/integration/components/related-resources/add-test.ts b/web/tests/integration/components/related-resources/add-test.ts
@@ -40,7 +40,7 @@ module("Integration | Component | related-resources/add", function (hooks) {
 
     const reducerFunction = (
       acc: Record<string, HermesDocument>,
-      document: { attrs: HermesDocument },
+      document: { attrs: HermesDocument }
     ) => {
       acc[document.attrs.objectID] = document.attrs;
       return acc;
@@ -51,13 +51,10 @@ module("Integration | Component | related-resources/add", function (hooks) {
     const getFirstFourRecords = (documents: any) => {
       return Object.keys(documents)
         .slice(0, 4)
-        .reduce(
-          (acc, key) => {
-            acc[key] = documents[key];
-            return acc;
-          },
-          {} as Record<string, HermesDocument>,
-        );
+        .reduce((acc, key) => {
+          acc[key] = documents[key];
+          return acc;
+        }, {} as Record<string, HermesDocument>);
     };
 
     suggestions = getFirstFourRecords(suggestions);
@@ -69,7 +66,7 @@ module("Integration | Component | related-resources/add", function (hooks) {
       (
         dd: XDropdownListAnchorAPI | null,
         query: string,
-        shouldIgnoreDelay?: boolean,
+        shouldIgnoreDelay?: boolean
       ) => {
         if (query === "") {
           this.set("shownDocuments", suggestions);
@@ -82,7 +79,7 @@ module("Integration | Component | related-resources/add", function (hooks) {
           this.set("shownDocuments", getFirstFourRecords(matches));
         }
         return Promise.resolve();
-      },
+      }
     );
 
     this.set("getObject", (dd: XDropdownListAnchorAPI | null, id: string) => {
@@ -153,11 +150,11 @@ module("Integration | Component | related-resources/add", function (hooks) {
     // Here, we set it to resolve a promise after a timeout to
     // allow us to capture its `isRunning` state.
     this.set("search", () => {
-      return new Promise<void>((resolve) => {
+      return new Promise((resolve) => {
         setTimeout(() => {
           resolve();
         }, 1000);
-      });
+      }) as Promise<void>;
     });
 
     await render<RelatedResourcesAddTestContext>(hbs`
@@ -304,4 +301,4 @@ module("Integration | Component | related-resources/add", function (hooks) {
       .dom("[data-test-related-resources-search-loading-icon]")
       .exists("a loading icon is shown when `searchIsRunning` is true");
   });
-});
+});